Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor proxy config #606

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Refactor proxy config #606

merged 2 commits into from
Dec 21, 2023

Conversation

fancycode
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Dec 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7288178589

  • 191 of 334 (57.19%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.4%) to 55.874%
Changes Missing Coverage Covered Lines Changed/Added Lines %
proxy_config_etcd.go 84 118 71.19%
proxy_config_static.go 107 143 74.83%
mcu_proxy.go 0 73 0.0%
Files with Coverage Reduction New Missed Lines %
mcu_proxy.go 9 3.13%
Totals Coverage Status
Change from base Build 7267344896: 1.4%
Covered Lines: 7534
Relevant Lines: 13484
💛 - Coveralls

@fancycode fancycode force-pushed the refactor-proxy-config branch from 11e9ecd to 48cfe24 Compare December 2, 2023 19:35
@fancycode fancycode force-pushed the refactor-proxy-config branch from 48cfe24 to ba90be4 Compare December 21, 2023 10:31
@fancycode fancycode force-pushed the refactor-proxy-config branch from ba90be4 to 8f29330 Compare December 21, 2023 10:50
@fancycode fancycode marked this pull request as ready for review December 21, 2023 12:37
@fancycode fancycode merged commit 5fd0efa into master Dec 21, 2023
15 checks passed
@fancycode fancycode deleted the refactor-proxy-config branch December 21, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fancycode @coveralls