-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass link_mode
to LAS creation
#4145
base: master
Are you sure you want to change the base?
Conversation
94938f1
to
cf24a64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one non-blocking suggestion
StripePayments/StripePayments/Source/API Bindings/STPAPIClient+LinkAccountSession.swift
Outdated
Show resolved
Hide resolved
StripePaymentSheet- public var paymentMethodLayout: StripePaymentSheet.PaymentSheet.PaymentMethodLayout
- public enum PaymentMethodLayout {
- case horizontal
- case vertical
- case automatic
- public static func == (a: StripePaymentSheet.PaymentSheet.PaymentMethodLayout, b: StripePaymentSheet.PaymentSheet.PaymentMethodLayout) -> Swift.Bool
- public func hash(into hasher: inout Swift.Hasher)
- public var hashValue: Swift.Int {
- get
- }
- } If you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
279d1e6
to
919161f
Compare
🚨 New dead code detected in this PR: OpenAuthenticatedWebViewMessageHandler.swift:11 warning: Class 'OpenAuthenticatedWebViewMessageHandler' is unused
ReturnedFromAuthenticatedWebViewSender.swift:11 warning: Struct 'ReturnedFromAuthenticatedWebViewSender' is unused Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
919161f
to
87edaa8
Compare
Summary
This pull request adds a
link_mode
field to the LAS creation request. If Link is not enabled, we sendLINK_DISABLED
just like Web does.(cc @selinafeng-stripe)
Motivation
BANKCON-15655
Testing
Changelog