Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass link_mode to LAS creation #4145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Oct 16, 2024

Summary

This pull request adds a link_mode field to the LAS creation request. If Link is not enabled, we send LINK_DISABLED just like Web does.

(cc @selinafeng-stripe)

Motivation

BANKCON-15655

Testing

Changelog

@tillh-stripe tillh-stripe requested review from a team as code owners October 16, 2024 14:22
@tillh-stripe tillh-stripe marked this pull request as draft October 16, 2024 14:22
@tillh-stripe tillh-stripe force-pushed the tillh/pass-link-mode-to-las-creation branch 2 times, most recently from 94938f1 to cf24a64 Compare October 16, 2024 18:38
@tillh-stripe tillh-stripe marked this pull request as ready for review October 16, 2024 22:06
mats-stripe
mats-stripe previously approved these changes Oct 16, 2024
Copy link
Collaborator

@mats-stripe mats-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one non-blocking suggestion

Copy link

⚠️ Public API changes detected:

StripePaymentSheet

- public var paymentMethodLayout: StripePaymentSheet.PaymentSheet.PaymentMethodLayout
- public enum PaymentMethodLayout {
- case horizontal
- case vertical
- case automatic
- public static func == (a: StripePaymentSheet.PaymentSheet.PaymentMethodLayout, b: StripePaymentSheet.PaymentSheet.PaymentMethodLayout) -> Swift.Bool
- public func hash(into hasher: inout Swift.Hasher)
- public var hashValue: Swift.Int {
- get
- }
- }

If you are adding a new public API consider the following:

  • Do these APIs need to be public or can they be protected with @_spi(STP)?
  • If these APIs need to be public, assess whether they require an API review.

If you are modifying or removing a public API:

  • Does this require a breaking version change?
  • Do these changes require API review?

If you confirm these APIs need to be added/updated and have undergone necessary review, add the label modifies public API to this PR to acknowledge and bypass this check.

ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with master.

@tillh-stripe tillh-stripe force-pushed the tillh/pass-link-mode-to-las-creation branch from 279d1e6 to 919161f Compare October 18, 2024 20:27
Copy link

🚨 New dead code detected in this PR:

OpenAuthenticatedWebViewMessageHandler.swift:11 warning: Class 'OpenAuthenticatedWebViewMessageHandler' is unused
ReturnedFromAuthenticatedWebViewSender.swift:11 warning: Struct 'ReturnedFromAuthenticatedWebViewSender' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

@tillh-stripe tillh-stripe force-pushed the tillh/pass-link-mode-to-las-creation branch from 919161f to 87edaa8 Compare October 18, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants