Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PromptPay LPM. #9435

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add PromptPay LPM. #9435

wants to merge 1 commit into from

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed            
          ├───────────┬───────────┬──────────┼───────────┬───────────┬───────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff      
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼───────────
      dex │   3.9 MiB │   3.9 MiB │   +291 B │   8.6 MiB │   8.6 MiB │  +1.6 KiB 
     arsc │   2.3 MiB │   2.3 MiB │   +908 B │   2.3 MiB │   2.3 MiB │    +908 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │  25.6 KiB │  25.6 KiB │       0 B 
      res │ 933.6 KiB │ 938.5 KiB │ +4.9 KiB │   1.5 MiB │   1.5 MiB │ +10.5 KiB 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │       0 B 
    asset │   2.9 MiB │   2.9 MiB │    -11 B │   2.9 MiB │   2.9 MiB │     -11 B 
    other │   196 KiB │ 196.2 KiB │   +253 B │ 430.6 KiB │ 431.6 KiB │    +992 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼───────────
    total │  12.8 MiB │  12.9 MiB │ +6.3 KiB │  21.8 MiB │  21.8 MiB │   +14 KiB 

 DEX     │ old   │ new   │ diff            
─────────┼───────┼───────┼─────────────────
   files │     1 │     1 │   0             
 strings │ 42663 │ 42674 │ +11 (+34 -23)   
   types │ 14153 │ 14156 │  +3 (+25 -22)   
 classes │ 11780 │ 11782 │  +2 (+4 -2)     
 methods │ 60470 │ 60484 │ +14 (+449 -435) 
  fields │ 40103 │ 40112 │  +9 (+395 -386) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  242 │  242 │  0         
 entries │ 6253 │ 6255 │ +2 (+2 -0)
APK 
     compressed      │     uncompressed     │                               
──────────┬──────────┼───────────┬──────────┤                               
 size     │ diff     │ size      │ diff     │ path                          
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  2.5 KiB │ +2.5 KiB │   5.3 KiB │ +5.3 KiB │ + res/W_.xml                  
  2.5 KiB │ +2.5 KiB │   5.3 KiB │ +5.3 KiB │ + res/tK.xml                  
  2.3 MiB │   +908 B │   2.3 MiB │   +908 B │ ∆ resources.arsc              
  3.9 MiB │   +291 B │   8.6 MiB │ +1.6 KiB │ ∆ classes.dex                 
 50.2 KiB │    +85 B │ 118.4 KiB │   +164 B │ ∆ META-INF/MANIFEST.MF        
 53.5 KiB │    +84 B │ 118.5 KiB │   +164 B │ ∆ META-INF/CERT.SF            
  3.6 KiB │    +82 B │  29.2 KiB │   +664 B │ ∆ lpms.json                   
  7.8 KiB │    -11 B │   7.7 KiB │    -11 B │ ∆ assets/dexopt/baseline.prof 
  1.2 KiB │     +2 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA           
    848 B │     +1 B │   1.8 KiB │      0 B │ ∆ res/8Q.xml                  
    707 B │     +1 B │   1.3 KiB │      0 B │ ∆ res/UK.xml                  
    952 B │     -1 B │   2.5 KiB │      0 B │ ∆ res/de.xml                  
  1.1 KiB │     +1 B │   3.2 KiB │      0 B │ ∆ res/nn.xml                  
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  6.4 MiB │ +6.3 KiB │  11.2 MiB │  +14 KiB │ (total)
DEX 
STRINGS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   42663 │ 42674 │ +11 (+34 -23) 
  
  + DisplayPayNowDetails
  + DisplayPayNowDetails(hostedVoucherUrl=
  + LP6/P;
  + LT6/l3;
  + Lb6/s;
  + Lm6/M;
  + PromptPay
  + THB
  + [LT6/Q2;
  + [LT6/V2;
  + [LT6/b3;
  + [LT6/l3;
  + [Lb6/h;
  + [Lb6/j;
  + [Lb7/a;
  + [Lb7/f;
  + [Lb7/k;
  + [Lcom/stripe/android/stripecardscan/scanui/d;
  + [Lf6/d;
  + [Lg6/E0;
  + [Lg8/e;
  + [Li7/c;
  + [Lm6/L;
  + [Ln6/H;
  + [Ln6/K;
  + [Ln6/a;
  + [Ln6/c;
  + [Ln6/e;
  + [Ln6/q;
  + hosted_instructions_url
  + promptpay
  + promptpay_display_qr_code
  + thb
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"efd9c4a","r8-mode":"full","version":"8.5.35"}
  
  - Lb7/r;
  - Ln6/M;
  - [LT6/R2;
  - [LT6/W2;
  - [LT6/f3;
  - [Lb6/g;
  - [Lb6/i;
  - [Lb7/e;
  - [Lb7/j;
  - [Lb7/q;
  - [Lcom/stripe/android/stripecardscan/scanui/c;
  - [Lf6/c;
  - [Lg6/D0;
  - [Lg8/d;
  - [Li7/b;
  - [Lm6/K;
  - [Ln6/I;
  - [Ln6/L;
  - [Ln6/b;
  - [Ln6/d;
  - [Ln6/f;
  - [Ln6/r;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"e6d2182","r8-mode":"full","version":"8.5.35"}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   14153 │ 14156 │ +3 (+25 -22) 
  
  + LP6/P;
  + LT6/l3;
  + Lb6/s;
  + Lm6/M;
  + [LT6/Q2;
  + [LT6/V2;
  + [LT6/b3;
  + [LT6/l3;
  + [Lb6/h;
  + [Lb6/j;
  + [Lb7/a;
  + [Lb7/f;
  + [Lb7/k;
  + [Lcom/stripe/android/stripecardscan/scanui/d;
  + [Lf6/d;
  + [Lg6/E0;
  + [Lg8/e;
  + [Li7/c;
  + [Lm6/L;
  + [Ln6/H;
  + [Ln6/K;
  + [Ln6/a;
  + [Ln6/c;
  + [Ln6/e;
  + [Ln6/q;
  
  - Lb7/r;
  - Ln6/M;
  - [LT6/R2;
  - [LT6/W2;
  - [LT6/f3;
  - [Lb6/g;
  - [Lb6/i;
  - [Lb7/e;
  - [Lb7/j;
  - [Lb7/q;
  - [Lcom/stripe/android/stripecardscan/scanui/c;
  - [Lf6/c;
  - [Lg6/D0;
  - [Lg8/d;
  - [Li7/b;
  - [Lm6/K;
  - [Ln6/I;
  - [Ln6/L;
  - [Ln6/b;
  - [Ln6/d;
  - [Ln6/f;
  - [Ln6/r;
  

METHODS:

   old   │ new   │ diff            
  ───────┼───────┼─────────────────
   60470 │ 60484 │ +14 (+449 -435) 
  
  + A0.i <init>(G)
  + B1.i <init>(u, G)
  + B5.n <init>(U0, h3)
  + B5.v <init>(e, boolean, h1, u, a)
  + D1.k <init>(f2, d2, Application, Z, k0, e)
  + F.e e0(d3) → d3
  + G5.A0 <init>(F)
  + G5.B <init>(F, a, String)
  + G5.C <init>(a, F)
  + G5.E <init>(a, p)
  + G5.G a(String, String, k3, f, s, t, u, v, d) → Object
  + G5.H <init>(a, F)
  + G5.I <init>(a, F)
  + G5.U <init>(i, J, d, a)
  + G5.Y <init>(Z, E0, h1, K2, boolean, d)
  + G5.Z <init>(i, a)
  + G5.a <init>(a, F)
  + G5.d0 <init>(G, a)
  + G5.d <init>(P, F, a)
  + G5.f0 <init>(F, d, a)
  + G5.f <init>(P, F, a)
  + G5.h0 <init>(F, a, String)
  + G5.i0 <init>(a, p)
  + G5.i <init>(G, u, a)
  + G5.k0 <init>(p, G, J, f)
  + G5.l0 <init>(r, w, d, F)
  + G5.n <init>(p)
  + G5.n c(Throwable, k3) → Throwable
  + G5.o0 <init>(P, F, a)
  + G5.o <init>(a, F)
  + G5.p <init>(s)
  + G5.s <init>(i, a)
  + G5.t0 <init>(Locale, a, d, L, F, i)
  + G5.u0 <init>(s)
  + G5.u <init>(G)
  + G5.v0 <init>(i, a)
  + G5.w <init>(i, a)
  + G5.x0 <init>(a, L, i)
  + G5.y0 <init>(p)
  + G5.z0 <init>(i)
  + I5.E <init>(m, P, w, J, t0, v0, B, F, p, d, Z, s)
  + J5.h <init>(c, P, b, F, w, A0, d)
  + K5.h <init>(d, P, L, U, w, w, F, B, d)
  + N5.v <init>(h, P, a, B, F, w, p, d, s)
  + N6.f a(d3, String) → e
  + N6.g a(String, q, d3, boolean) → boolean
  + O4.F e() → d3
  + O4.M e() → d3
  + O4.v e() → d3
  + O6.k <init>(d3, z1, boolean, boolean, List, c, String, w1, a, List, List, boolean, boolean, b, q, z0, boolean)
  + P0.c S(Context, e) → Intent
  + P0.c X(d3)
  + P5.i <init>(d, P, B, r, w, F, d)
  + P6.P <clinit>()
  + P6.P a() → k1
  + P6.P b(boolean) → Set
  + P6.P c() → boolean
  + P6.P d() → u
  + P6.P e(k) → boolean
  + R2.c d(d3, int) → String
  + T5.y <init>(l, P, w, J, p, s, x0, z0, B, F, d, a, s)
  + T5.y j(h2, j) → k
  + T5.y k(k)
  + T6.I2 <init>(V2)
  + T6.P0 <init>(String, List, Long, long, H0, I0, String, K0, String, long, String, String, boolean, s1, String, String, StripeIntent_Status, StripeIntent_Usage, M0, N0, List, List, c3, String)
  + T6.P0 f() → c3
  + T6.Q2 <clinit>()
  + T6.Q2 <init>(String)
  + T6.Q2 describeContents() → int
  + T6.Q2 equals(Object) → boolean
  + T6.Q2 hashCode() → int
  + T6.Q2 toString() → String
  + T6.Q2 writeToParcel(Parcel, int)
  + T6.R2 d() → String
  + T6.S2 <init>(Uri, String)
  + T6.T2 <init>(String)
  + T6.U2 <init>(String, String, String, List)
  + T6.V2 
...✂
ARSC 
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6253 │ 6255 │ +2 (+2 -0) 
  + drawable/stripe_ic_paymentsheet_pm_promptpay
  + string/stripe_paymentsheet_payment_method_promptpay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jaynewstrom-stripe