-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3DS2 Analytics Delegate #9430
base: feature/3ds2-2.2
Are you sure you want to change the base?
3DS2 Analytics Delegate #9430
Conversation
@@ -200,3 +217,18 @@ class StripeThreeDs2ServiceImpl @VisibleForTesting internal constructor( | |||
private const val STRIPE_SDK_REFERENCE_NUMBER = "3DS_LOA_SDK_STIN_020100_00142" | |||
} | |||
} | |||
|
|||
class AnalyticsSingleton private constructor() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work because it will not survive process death. I discussed with the team and we decided a java service provider will be the best approach. Can you remove this and replace with a ServiceLoader
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sorry, thought I posted a comment about the Singleton to ask how your team wanted to handle that. 👍🏼
Summary
Adds a 3DS2 Analytics Delegate
Motivation
This allow the payments SDK to have finer grain control over information provided by the 3DS2 SDK, so that additional analytics information can be provided.
Testing