-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the failure due to reaching the servlet capacity when getting user tasks #10768
Conversation
230e789
to
1b0ff08
Compare
/azp run build |
Azure Pipelines successfully started running 1 pipeline(s). |
f6e9311
to
3dd12c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small suggestions, but otherwise LGTM
...strimzi/operator/cluster/operator/resource/cruisecontrol/CruiseControlUserTasksResponse.java
Show resolved
Hide resolved
...strimzi/operator/cluster/operator/resource/cruisecontrol/CruiseControlUserTasksResponse.java
Show resolved
Hide resolved
.../main/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java
Outdated
Show resolved
Hide resolved
.../main/java/io/strimzi/operator/cluster/operator/assembly/KafkaRebalanceAssemblyOperator.java
Outdated
Show resolved
Hide resolved
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Thank you all for reviewing the PR. I pushed an update addressing the suggestions from @katheris. |
@ppatierno can you please kick off the build and regression tests again? |
/azp run build |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
@tinaselenge I see some failures on regression while one could not be involved, can you double check the failure on |
…user tasks Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
Signed-off-by: Gantigmaa Selenge <[email protected]>
8086324
to
62f12d0
Compare
Looks like testAutoKafkaRebalanceScaleUpScaleDown was added recently and did not yet exist in my branch. I rebased to main and then ran this test locally which then passed. I'm also running KafkaRollerST#testKafkaDoesNotRollsWhenTopicIsUnderReplicated locally just in case, as this test had timed out during regression run but it shouldn't be related to the changes anyway. |
I ran the failed jobs again, let's see. |
Regression was ok. Going to merge this one. |
Thank you @ppatierno ! |
Type of change
Select the type of your PR
Description
If failed to get user tasks due to reaching the servlet capacity, it will no longer transition the KafkaRebalance status to NotReady. Instead, KafkaRebalance status will not be changed and in the next reconciliation, it will retry getting the user tasks again. The operator will also report a warning message.
Resolves #10704
Checklist
Please go through this checklist and make sure all applicable tasks have been done