Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(connectors): adds procedures to manage connector offsets #10661

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Oct 1, 2024

Documentation

Adds procedures to manage Kafka Connect connectors.
Plus note on using the same configuration for MM2 connectors.
Plus a couple of minor updates and typo fixes

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@PaulRMellor PaulRMellor added this to the 0.44.0 milestone Oct 1, 2024
@PaulRMellor PaulRMellor requested review from katheris and a team October 1, 2024 15:58
@PaulRMellor PaulRMellor self-assigned this Oct 1, 2024
@PaulRMellor
Copy link
Contributor Author

Thanks for the review @scholzj
I've updated the intros to be clear about the stop/starts
For verification of resets and alterations, I've included a step to link back to the listing procedure

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@PaulRMellor
Copy link
Contributor Author

Thanks for the review @katheris
As advised, I've expanded the MM2 section

Copy link
Contributor

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PaulRMellor, LGTM

@scholzj scholzj merged commit 2b8c900 into strimzi:main Oct 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants