Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support datadog Autodiscovery v2 api annotation #1199

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ericsyh
Copy link
Member

@ericsyh ericsyh commented Dec 30, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
@ericsyh ericsyh requested review from a team as code owners December 30, 2024 08:08
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Dec 30, 2024
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
@ericsyh ericsyh requested review from tuteng and ignacioli December 30, 2024 08:17
"jvm_threads_current": "gauge",
"jvm_threads_daemon": "gauge",
"jvm_threads_peak": "gauge",
"jvm_threads_started_total": "gauge",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The metrics with the _total subfix are counter-type. https://github.com/DataDog/integrations-core/blob/master/openmetrics/datadog_checks/openmetrics/data/conf.yaml.example#L97-L101

Note: To collect counter metrics with names ending in _total, specify the metric name without the _total
suffix. For example, to collect the counter metric promhttp_metric_handler_requests_total, specify
promhttp_metric_handler_requests. This submits to Datadog the metric name appended with .count`.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 76359e3

Comment on lines 191 to 192
"pulsar_in_bytes_total": "counter",
"pulsar_in_messages_total": "counter",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: To collect counter metrics with names ending in _total, specify the metric name without the _total
suffix. For example, to collect the counter metric promhttp_metric_handler_requests_total, specify
promhttp_metric_handler_requests. This submits to Datadog the metric name appended with .count.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 76359e3

Signed-off-by: ericsyh <[email protected]>
@ericsyh
Copy link
Member Author

ericsyh commented Dec 31, 2024

@ignacioli updated based on your comment, pls help take a look again.

@ignacioli
Copy link
Contributor

Seems the metric override configs should be put in metadata. annotations.ad.datadoghq.com/prometheus-example.checks. instances[metrics]. AD Annotations v2 doesn’t support type_overrides for now. see https://docs.datadoghq.com/containers/kubernetes/prometheus/?tab=kubernetesadv2#metric-collection-with-prometheus-annotations

Copy link
Contributor

@ignacioli ignacioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants