-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support datadog Autodiscovery v2 api annotation #1199
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
"jvm_threads_current": "gauge", | ||
"jvm_threads_daemon": "gauge", | ||
"jvm_threads_peak": "gauge", | ||
"jvm_threads_started_total": "gauge", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metrics with the _total
subfix are counter-type. https://github.com/DataDog/integrations-core/blob/master/openmetrics/datadog_checks/openmetrics/data/conf.yaml.example#L97-L101
Note: To collect counter metrics with names ending in
_total
, specify the metric name without the_total
suffix. For example, to collect the counter metricpromhttp_metric_handler_requests_total
, specify
promhttp_metric_handler_requests. This submits to Datadog the metric name appended with
.count`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 76359e3
"pulsar_in_bytes_total": "counter", | ||
"pulsar_in_messages_total": "counter", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: To collect counter metrics with names ending in
_total
, specify the metric name without the_total
suffix. For example, to collect the counter metricpromhttp_metric_handler_requests_total
, specify
promhttp_metric_handler_requests
. This submits to Datadog the metric name appended with.count
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 76359e3
Signed-off-by: ericsyh <[email protected]>
@ignacioli updated based on your comment, pls help take a look again. |
Seems the metric override configs should be put in |
Signed-off-by: ericsyh <[email protected]>
Signed-off-by: ericsyh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)