Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert const enums to regular enums #1430

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

Conversation

avacreeth
Copy link
Member

This package exports const enums instead of regular enums. References to a const enum are inlined at compile time, so there is no runtime object associated with the enum. Most modern javascript bundlers compile typescript with isolatedModules: true which means that type checking doesn't happen across module boundaries, and therefore the enums cannot be inlined.

Removing the const keyword from these enums means that the compiled javascript build object for module.ts will contain runtime objects that can be used to access enum values.

@summeroff summeroff force-pushed the remove_const_enums branch from 9af8599 to a6cfe98 Compare April 9, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant