Pdykstra cmd4 #20
Open
Pdykstra cmd4 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e unclear because of major architecture changes between v1 and v3 (there is no v2, it was thrown away), command line parameters may need to be the same across all versions of CEF. Wrote this Friday, but fell asleep before pushing the changes. If anyone knows the correct way to handle this let me know, but this might be the correct way because a lot of parameters require restarting Chrome entirely to take effect.
…things in the format --abc, but rather --abc=true
|
Screenshot of framerate of browser, Ccrome's service/client encryption is not implemented, so some command line options will not work (ie streaming dom changes). Fixed cmake build error when the obs-panel function is enabled. |
|
Also on the edge of draft status, so there is some commented code that needs to be removed. Code Architecture isn't too clear (to me), so feel free to ask code to be moved if the code is in the wrong place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is larger than it looks because autoformatting is turned on. Everything seems to be working right now, but the settings come back without the command line parameters (need to fix before push). However they are saved and loaded correctly by the framework. Browser seems to be starting and restarting as expected, but a little more testing should also be done before a push.
Mutexes are used to prevent multiple browsers from starting at the same time. I'm not sure if this is needed or not, so if anyone has any expertise on the subject.