Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary logs from proxies #60

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

GitGab19
Copy link
Collaborator

Closes #42.
This PR also specify grafana/loki:2.9.8 in both docker-composess, since there has been some breaking changes in the latest which cause loki to stop working (cc @Shourya742)

@GitGab19 GitGab19 force-pushed the cleanup-proxy-logs branch 2 times, most recently from d645f48 to 5c68259 Compare October 18, 2024 15:31
Copy link
Collaborator

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK. Thanks for highlighting the breaking changes. Regarding the logs for this issue, I was thinking of adding a logger to the proxies and allowing the user to choose their preferred log level for the tool. Let me know your thoughts on this.

@GitGab19
Copy link
Collaborator Author

It makes sense, we could open an issue for that.
This PR removes all the unnecessary logs I found in both SV1 and SV2 proxies. I moved the most important ones where something is wrong (the else path typically). In this way we should have all the necessary ones to debug.
But yeah, if you want to dig into logger in the future, feel free to create an issue!

Copy link
Collaborator

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@Shourya742
Copy link
Collaborator

It makes sense, we could open an issue for that. This PR removes all the unnecessary logs I found in both SV1 and SV2 proxies. I moved the most important ones where something is wrong (the else path typically). In this way we should have all the necessary ones to debug. But yeah, if you want to dig into logger in the future, feel free to create an issue!

Cool logging an issue for this...

@GitGab19 GitGab19 merged commit 0383aa2 into stratum-mining:main Oct 21, 2024
5 checks passed
@GitGab19 GitGab19 deleted the cleanup-proxy-logs branch October 21, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup logs from sv1-custom-proxy
2 participants