Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM: Preset loading esbuild #29377

Draft
wants to merge 6 commits into
base: norbert/esm-preset-loading
Choose a base branch
from

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Oct 16, 2024

What I did

  • replace esbuild-register with esbuild
  • upgrade jiti to support import.meta in our scripts/code

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.7 MB 78.7 MB 4.47 kB Infinity 0%
initSize 146 MB 146 MB 31.1 kB Infinity 0%
diffSize 67.5 MB 67.5 MB 26.6 kB Infinity 0%
buildSize 6.79 MB 6.79 MB 0 B - 0%
buildSbAddonsSize 1.5 MB 1.5 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.83 MB 1.83 MB 0 B - 0%
buildSbPreviewSize 270 kB 270 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.8 MB 3.8 MB 0 B - 0%
buildPreviewSize 2.99 MB 2.99 MB 0 B - 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 22.7s 18.2s -4s -523ms -Infinity 🔰-24.8%
generateTime 18.6s 21.3s 2.7s Infinity 🔺12.7%
initTime 11.8s 14.1s 2.2s Infinity 🔺15.9%
buildTime 11.5s 10.2s -1s -342ms -Infinity 🔰-13.1%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.6s 6.6s 35ms Infinity 0.5%
devManagerResponsive 4.1s 4.1s 30ms Infinity 0.7%
devManagerHeaderVisible 542ms 537ms -5ms -Infinity -0.9%
devManagerIndexVisible 573ms 570ms -3ms -Infinity -0.5%
devStoryVisibleUncached 705ms 1s 394ms Infinity 🔺35.9%
devStoryVisible 575ms 569ms -6ms -Infinity -1.1%
devAutodocsVisible 423ms 443ms 20ms Infinity 4.5%
devMDXVisible 455ms 534ms 79ms Infinity 🔺14.8%
buildManagerHeaderVisible 469ms 576ms 107ms Infinity 🔺18.6%
buildManagerIndexVisible 473ms 651ms 178ms Infinity 🔺27.3%
buildStoryVisible 501ms 652ms 151ms Infinity 🔺23.2%
buildAutodocsVisible 432ms 594ms 162ms Infinity 🔺27.3%
buildMDXVisible 426ms 533ms 107ms Infinity 🔺20.1%

Copy link

nx-cloud bot commented Oct 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c4c050a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen self-assigned this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant