Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Benchmark individual package's sizes and dependencies #29356

Draft
wants to merge 13 commits into
base: next
Choose a base branch
from

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Oct 15, 2024

Closes #29322

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 78.7 MB 78.7 MB 0 B 1.58 0%
initSize 147 MB 147 MB -1.55 kB 1.43 0%
diffSize 68.3 MB 68.3 MB -1.55 kB 1.19 0%
buildSize 6.79 MB 6.79 MB -225 B -1.95 0%
buildSbAddonsSize 1.5 MB 1.5 MB 30 B 1.36 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.83 MB 1.83 MB -279 B -1.98 0%
buildSbPreviewSize 270 kB 270 kB 12 B 1.36 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.8 MB 3.8 MB -237 B -1.96 0%
buildPreviewSize 2.99 MB 2.99 MB 12 B 1.36 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 20.6s 18.5s -2s -47ms 1.21 -11%
generateTime 20.9s 22.5s 1.5s 0.15 6.9%
initTime 13.9s 14.2s 367ms -0.13 2.6%
buildTime 9.2s 9.2s 6ms 0.67 0.1%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.7s 5.9s 143ms -0.47 2.4%
devManagerResponsive 4s 4s -25ms -0.16 -0.6%
devManagerHeaderVisible 497ms 580ms 83ms -0.17 14.3%
devManagerIndexVisible 535ms 610ms 75ms -0.21 12.3%
devStoryVisibleUncached 625ms 912ms 287ms -0.39 31.5%
devStoryVisible 530ms 608ms 78ms -0.24 12.8%
devAutodocsVisible 461ms 515ms 54ms -0.13 10.5%
devMDXVisible 418ms 485ms 67ms -0.44 13.8%
buildManagerHeaderVisible 486ms 498ms 12ms -0.41 2.4%
buildManagerIndexVisible 500ms 501ms 1ms -0.54 0.2%
buildStoryVisible 524ms 570ms 46ms -0.23 8.1%
buildAutodocsVisible 463ms 397ms -66ms -1 -16.6%
buildMDXVisible 453ms 389ms -64ms -1.11 -16.5%

Copy link

nx-cloud bot commented Oct 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 00be90c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JReinhold JReinhold changed the title 29322-set-up-tooling-to-warnhighlight-on-regressions-in-package-size-and-dependency-graph Build: Benchmark individual package's sizes and dependencies Oct 15, 2024
@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up tooling to warn/highlight on regressions in package size and dependency graph
1 participant