Call it e2e instead of vrt

stevenpetryk · Mar 7, 2024 · 5605967 · 5605967
1 parent d877f22
commit 5605967
Show file tree

Hide file tree

Showing 2 changed files with 60 additions and 58 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -3,62 +3,62 @@ name: Mafs CI
 on: [push]
 
 jobs:
-  # build:
-  #   runs-on: ubuntu-latest
-  #   timeout-minutes: 2
-  #   steps:
-  #     - uses: actions/checkout@v4
-  #     - uses: pnpm/action-setup@v3
-  #     - uses: actions/setup-node@v4
-  #       with:
-  #         cache: "pnpm"
-  #     - run: pnpm install
-  #     - run: pnpm build
+  build:
+    runs-on: ubuntu-latest
+    timeout-minutes: 2
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v3
+      - uses: actions/setup-node@v4
+        with:
+          cache: "pnpm"
+      - run: pnpm install
+      - run: pnpm build
 
-  # tests:
-  #   runs-on: ubuntu-latest
-  #   timeout-minutes: 2
-  #   steps:
-  #     - uses: actions/checkout@v4
-  #     - uses: pnpm/action-setup@v3
-  #     - uses: actions/setup-node@v4
-  #       with:
-  #         cache: "pnpm"
-  #     - run: pnpm install
-  #     - run: pnpm test:unit
+  tests:
+    runs-on: ubuntu-latest
+    timeout-minutes: 2
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v3
+      - uses: actions/setup-node@v4
+        with:
+          cache: "pnpm"
+      - run: pnpm install
+      - run: pnpm test:unit
 
-  # check-format:
-  #   runs-on: ubuntu-latest
-  #   timeout-minutes: 2
-  #   steps:
-  #     - uses: actions/checkout@v4
-  #     - uses: pnpm/action-setup@v3
-  #     - uses: actions/setup-node@v4
-  #       with:
-  #         cache: "pnpm"
-  #     - run: pnpm install
-  #     - run: pnpm format:check
+  check-format:
+    runs-on: ubuntu-latest
+    timeout-minutes: 2
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v3
+      - uses: actions/setup-node@v4
+        with:
+          cache: "pnpm"
+      - run: pnpm install
+      - run: pnpm format:check
 
-  # lint:
-  #   runs-on: ubuntu-latest
-  #   timeout-minutes: 2
-  #   steps:
-  #     - uses: actions/checkout@v4
-  #     - uses: pnpm/action-setup@v3
-  #     - uses: actions/setup-node@v4
-  #       with:
-  #         cache: "pnpm"
-  #     - run: pnpm install
-  #     - run: pnpm lint
+  lint:
+    runs-on: ubuntu-latest
+    timeout-minutes: 2
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v3
+      - uses: actions/setup-node@v4
+        with:
+          cache: "pnpm"
+      - run: pnpm install
+      - run: pnpm lint
 
-  # tsc:
-  #   runs-on: ubuntu-latest
-  #   timeout-minutes: 2
-  #   steps:
-  #     - uses: actions/checkout@v4
-  #     - uses: pnpm/action-setup@v3
-  #     - uses: actions/setup-node@v4
-  #       with:
-  #         cache: "pnpm"
-  #     - run: pnpm install
-  #     - run: pnpm tsc
+  tsc:
+    runs-on: ubuntu-latest
+    timeout-minutes: 2
+    steps:
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v3
+      - uses: actions/setup-node@v4
+        with:
+          cache: "pnpm"
+      - run: pnpm install
+      - run: pnpm tsc
diff --git a/.github/workflows/vrt.yml → .github/workflows/e2e.yml b/.github/workflows/vrt.yml → .github/workflows/e2e.yml
@@ -1,21 +1,23 @@
-name: Mafs Visual Tests
+name: Mafs End-to-End (E2E) Tests
 
 on:
   pull_request:
     types: [labeled, synchronize]
 
 jobs:
-  visual-tests:
+  e2e-tests:
     runs-on: ubuntu-latest
     timeout-minutes: 5
-    if: contains(github.event.pull_request.labels.*.name, 'visual-changes')
+    if: contains(github.event.pull_request.labels.*.name, 'run-e2e-tests')
     steps:
       - uses: actions/checkout@v4
       - uses: pnpm/action-setup@v3
       - uses: actions/setup-node@v4
         with:
           cache: "pnpm"
       - run: pnpm install
+      # TODO: cache this step, it takes forever. Playwright puts the browsers in ~/.cache somewhere.
+      # It also doesn't feel very reproducible.
       - name: Install Playwright Browsers
         run: pnpm playwright install --with-deps
       - run: pnpm test:e2e