Moved TableCommitMetaStoreWorker to nessie-services #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunos-bq
force-pushed
the
store-worker-move
branch
from
eac3a02
to
bef5b85
Compare
Repository owner
deleted a comment from
codecov-io
Feb 5, 2021
brunos-bq
force-pushed
the
store-worker-move
branch
from
bef5b85
to
23bbee7
Compare
tifflhl
reviewed
Feb 5, 2021
brunos-bq
force-pushed
the
store-worker-move
branch
from
23bbee7
to
a1c60fa
Compare
|
Are there unit/integration tests related to TableCommitMetaStoreWorker that need to be moved as well? |
Repository owner
deleted a comment from
codecov-io
Feb 5, 2021
|
@tifflhl Other than VersionStoreFactory.java, TableCommitMetaStoreWorker isn't called anywhere else in the code. No tests refer to that class. |
|
My code review comments are resolved. Lgtm. |
Repository owner
deleted a comment from
codecov-io
Feb 5, 2021
brunos-bq
force-pushed
the
store-worker-move
branch
3 times, most recently
from
19289c9
to
34bb8a4
Compare
brunos-bq
force-pushed
the
store-worker-move
branch
from
34bb8a4
to
4699a91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I am moving the class TableCommitMetaStoreWorker from the nessie-quarkus subproject to the nessie-services project.
The reason for this move is to embed Nessie within Dremio.
Embedding Nessie in Dremio will instantiate the backend and expose Nessie API endpoints within the server running Dremio.
Standalone Nessie runs through Quarkus. Embedded Nessie will not use Quarkus.
In order to create a VersionStore, a StoreWorker is needed. Prior to that change, Dremio would have to depend on nessie-quarkus in order to instantiate a StoreWorker.
With this change, Dremio will now only depend on nessie-model and nessie-services, not importing anything related to Quarkus.