Added some styling methods #222
Conversation
Added methods for styling the selected and unselected colors and the background of the bottom navigation
| @@ -9,7 +9,7 @@ buildscript { | |||
| google() | |||
| } | |||
| dependencies { | |||
| classpath "com.android.tools.build:gradle:$gradleAndroidVersion" | |||
There was a problem hiding this comment.
Please, modify gradleAndroidVersion variable above.
|
|
||
| @BindColor(R.color.ms_custom_button_text_color) | ||
| lateinit var customButtonColor: ColorStateList | ||
|
|
||
| @BindColor(R.color.custom_active_step_color) | ||
| @JvmField | ||
| var customActiveStepColor: Int = 0 |
There was a problem hiding this comment.
Please use the same code style as above using lateinit type modifier.
|
Hi @darkyelox, |
| */ | ||
| public void setActiveStepColor(@ColorInt int newActiveStepColor) { | ||
| mSelectedColor = newActiveStepColor; | ||
| mDottedProgressBar.setSelectedColor(newActiveStepColor); |
There was a problem hiding this comment.
I think this should be moved to mStepperType and handled by each subtype of AbstractStepperType instead. This way each stepper type can change it as needed (including the tabbed stepper).
I would also remove
applied to dotted or progress bars
from the JavaDoc and implement it for the tabbed stepper instead as the corresponding XML attribute does change the color of the tabs (so that we don't have inconsistencies between XML attribute and Java method).
As described above the logic for that should probably be in TabsStepperType and include:
mTabsContainer.setSelectedColor(stepperLayout.getSelectedColor());
+ what is done in TabsStepperType#onNewAdapter (tabs need to be recreated).
| * @param newBottomNavigationBackground the drawable | ||
| */ | ||
| public void setBottomNavigationBackground(@NonNull Drawable newBottomNavigationBackground){ | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) { |
There was a problem hiding this comment.
Please use ViewCompat.setBackground(mStepNavigation , newBottomNavigationBackground) instead.
| @@ -25,7 +25,7 @@ | |||
| * @author Piotr Zawadzki | |||
| */ | |||
| @LargeTest | |||
| public class SetButtonColorProgrammaticallyActivityTest extends AbstractActivityTest<SetButtonColorProgrammaticallyActivity> { | |||
| public class SetButtonColorProgrammaticallyActivityTest extends AbstractActivityTest<StyledProgrammaticallyActivity> { | |||
There was a problem hiding this comment.
Please rename the test class name to StyledProgrammaticallyActivityTest
|
i will do that when have some time, wait for it in next days, thanks |
|
Hi, is there any update on this PR? :) |
|
@darkyelox do you have any updates on this? :) |
I added some methods for change the colors for selected, unselected and bottom navigation background, i also refactor the color button activity sample for be more generic in styling and use the methods as example.