Allow context to be initialised with Any #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialise Context with Any by converting to dictionary Allow Any to be pushed onto a Context in a similar way Change Environment functions to use these new functions
|
This will fix #223 (comment) |
ilyapuchka
approved these changes
Jan 12, 2020
ilyapuchka
reviewed
Jan 12, 2020
Co-Authored-By: Ilya Puchka <[email protected]>
Co-Authored-By: Ilya Puchka <[email protected]>
Make init(object:environment) public Co-Authored-By: Ilya Puchka <[email protected]>
|
@ilyapuchka Is this getting merged in or do I need another approval? |
djbe
requested changes
Aug 13, 2020
Co-authored-by: David Jennes <[email protected]>
I'll have to have a good look at the code again. It was a wee while ago when I wrote this |
@djbe I had a look through the code again. None of the reflection code seems accessible at this point. Is there function that takes an object and converts it to a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given Mirror is being used to serialize objects that are members of the Context dictionary, it only seems logical we shouldn't be limited to initializing a Context with a dictionary. This PR adds the ability to initialize a context with Any
Initialize Context with Any by converting to dictionary
Allow Any to be pushed onto a Context in a similar way
Change Environment functions to use these new functions