Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Adeunis FTD decoder to the catalog #53

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ihebkhelifi
Copy link
Collaborator

No description provided.

Copy link
Contributor

@franckLG franckLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about the needs to upload all attributes. Only relevant one should be uploaded and stored.

longitude: {label:"longitude", unitCode: "DEG", datasetId: 'longitude:Raw'},
gps_quality: {label:"gpsQuality", unitCode: null, datasetId: 'gps_quality:Raw'},
hdop: {label:"hdop", unitCode: null, datasetId: 'hdop:Raw'},
sats: {label:"satellites", unitCode: null, datasetId: 'sats:Raw'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sats: Needed ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, corrected.


let parametersMapping = {
temperature: {label:"temperature", unitCode: "CEL", datasetId: 'temperature:Raw'},
trigger: {label:"trigger", unitCode: null, datasetId: 'trigger:Raw'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trigger: Needed ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, corrected.

trigger: {label:"trigger", unitCode: null, datasetId: 'trigger:Raw'},
latitude: {label:"latitude", unitCode: "DEG", datasetId: 'latitude:Raw'},
longitude: {label:"longitude", unitCode: "DEG", datasetId: 'longitude:Raw'},
gps_quality: {label:"gpsQuality", unitCode: null, datasetId: 'gps_quality:Raw'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gps_quality: needed ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, corrected.

ul_counter: {label:"uplinkCounter", unitCode: null, datasetId: 'ul_counter:Raw'},
dl_counter: {label:"downlinkCounter", unitCode: null, datasetId: 'dl_counter:Raw'},
battery_level: {label:"batteryLevel", unitCode: "VLT", datasetId: 'battery_level:Raw'},
rssi_dl: {label:"rssiDownlink", unitCode: "DBM", datasetId: 'rssi_dl:Raw'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use rssi and snr to avoid inventing a new attribute name. It is always DL here so no possble confusion

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use snr and rssi, but adding a datasetId 'Downlink:Raw' for these values, and another datasetId for the other snr/rssi from the gateway "gatewayId:7276ff002e05011c:Raw".
Updated.

hdop: {label:"hdop", unitCode: null, datasetId: 'hdop:Raw'},
sats: {label:"satellites", unitCode: null, datasetId: 'sats:Raw'},
ul_counter: {label:"uplinkCounter", unitCode: null, datasetId: 'ul_counter:Raw'},
dl_counter: {label:"downlinkCounter", unitCode: null, datasetId: 'dl_counter:Raw'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

downlinkCounter: needed ? We don't know about missed DL so not that relevant to know. Interest would be if from ul/dl counters we could infer areas where data transfers have been missed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values can be kept for the suggested idea.

latitude: {label:"latitude", unitCode: "DEG", datasetId: 'latitude:Raw'},
longitude: {label:"longitude", unitCode: "DEG", datasetId: 'longitude:Raw'},
gps_quality: {label:"gpsQuality", unitCode: null, datasetId: 'gps_quality:Raw'},
hdop: {label:"hdop", unitCode: null, datasetId: 'hdop:Raw'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hdop: needed ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, corrected.

gps_quality: {label:"gpsQuality", unitCode: null, datasetId: 'gps_quality:Raw'},
hdop: {label:"hdop", unitCode: null, datasetId: 'hdop:Raw'},
sats: {label:"satellites", unitCode: null, datasetId: 'sats:Raw'},
ul_counter: {label:"uplinkCounter", unitCode: null, datasetId: 'ul_counter:Raw'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ul_counter : does it provide any identifier that we could relate to a reception ion the gateway side ? If not, I don't really see an interest to colelct this parameter

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not send any identifier.
ul_counter can be kept for the idea suggested above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants