Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for stats/base/dists/t/mode #3913

Merged
merged 6 commits into from
Dec 29, 2024

Conversation

AadishJ
Copy link
Contributor

@AadishJ AadishJ commented Dec 14, 2024

Resolves #3876.

Description

What is the purpose of this pull request?

This pull request:

  • Adds a C implementation of the t mode.
  • Includes benchmarks for the C implementation.
  • Provides examples demonstrating the usage of the t mode in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 14, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 14, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/t/mode $\color{green}161/161$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}161/161$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@AadishJ AadishJ marked this pull request as draft December 14, 2024 23:18
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 14, 2024
@AadishJ AadishJ marked this pull request as ready for review December 14, 2024 23:47
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 14, 2024
@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/stats/base/dists/t/mode feat: add C implementation for stats/base/dists/t/mode Dec 15, 2024
@MeastroZI
Copy link
Contributor

MeastroZI commented Dec 15, 2024

@AadishJ Please refer this .

@AadishJ
Copy link
Contributor Author

AadishJ commented Dec 16, 2024

I have made those requested changes, please take a look.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 29, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 29, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/t/mode`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3913
Closes: https://github.com/stdlib-js/stdlib/issues/3876

Co-authored-by: Aadish Jain <firestorm@AadishJain>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 3736294 into stdlib-js:develop Dec 29, 2024
28 checks passed
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 1, 2025
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/t/mode
4 participants