Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/falling-factorial #3529

Merged
merged 7 commits into from
Jan 2, 2025
Merged

feat: add C implementation for math/base/special/falling-factorial #3529

merged 7 commits into from
Jan 2, 2025

Conversation

gunjjoshi
Copy link
Member

Progresses #649.

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_falling_factorial( const double x, const int32_t n )

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 12, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 12, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/falling-factorial $\color{red}298/322$
$\color{green}+92.55\%$ 		$\color{red}30/35$
$\color{green}+85.71\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{red}298/322$
$\color{green}+92.55\%$

The above coverage report was generated for the changes in this PR.

@gunjjoshi
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 1, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 1, 2025
Planeshifter
Planeshifter approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see any problems, so approving this PR. Thanks, @gunjjoshi!

lib/node_modules/@stdlib/math/base/special/falling-factorial/examples/index.js Outdated Show resolved Hide resolved
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 2, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 2, 2025
@Planeshifter Planeshifter merged commit b518ff1 into stdlib-js:develop Jan 2, 2025
26 of 27 checks passed
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
@gunjjoshi @stdlib-bot
@Planeshifter @0PrashantYadav0
feat: add C implementation for math/base/special/falling-factorial
0f21535 
PR-URL: stdlib-js#3529 
Ref: stdlib-js#649

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjjoshi @stdlib-bot @Planeshifter