Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add c implementation of math/base/special/minmaxn #3377

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Vinit-Pandit
Copy link
Contributor

Description

What is the purpose of this pull request?

This pull request: add c implementation of math/base/special/minmaxn

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 8, 2024
@Vinit-Pandit
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 8, 2024

Coverage Report

Package Statements Branches Functions Lines
math/base/special/minmaxn $\color{green}332/332$
$\color{green}+100.00\%$
$\color{green}38/38$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}332/332$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Vinit-Pandit
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 8, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 8, 2024
@Vinit-Pandit
Copy link
Contributor Author

Hi @gunjjoshi , would you mind taking a look at this when you have a moment? I'd really appreciate your feedback. Thank you!

@kgryte
Copy link
Member

kgryte commented Dec 10, 2024

@MeastroZI Thanks for working on this. I think we forgot to update #649 to exclude the variadic variants from that list.

That said, not opposed to finding something which works, and your initial draft seems like it could be workable. I think, for now, we should put this PR on the backburner, as I'll need to take a closer look.

@kgryte kgryte added Needs Discussion Needs further discussion. Feature Issue or pull request for adding a new feature. labels Dec 10, 2024
@Vinit-Pandit
Copy link
Contributor Author

I understand the need to revisit #649, and I’m glad the initial draft seems promising. I’ll be happy to make any necessary adjustments once you’ve had a chance to review it further. Looking forward to your thoughts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Needs Discussion Needs further discussion. Needs Review A pull request which needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementations to base special math functions (tracking issue)
3 participants