-
-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/exp2f
#3366
base: develop
Are you sure you want to change the base?
Conversation
/stdlib update-copyright-years |
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this PR! Looks great overall, but some changes will be needed for the JavaScript implementation.
In main.js
, we need to use the helper function
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
in order to ensure that all operations are done in a manner consistent with single-precision arithmetic. Recall that in JavaScript, all numbers are double-precision by default, so to emulate single-precision we must, in addition to using the single-precision variants of math functions, explicitly cast intermediate results and constants to single-precision floats.
good morning @Planeshifter! I've wrapped the intermediate results and final answers in |
Also, as mentioned in the questions section of the PR, what should i do about |
Resolves #649
Description
This pull request:
math/base/special/exp2f
Related Issues
This pull request:
Questions
What should i do about
benchmark/c/cephes
? that doesn't seem to compile locally and on the CI tests as well.Other
No.
Checklist
@stdlib-js/reviewers