Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/croundf #3061

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

gururaj1512
Copy link
Contributor

Resolves #649

Description

What is the purpose of this pull request?

stdlib_complex64_t stdlib_base_croundf( const stdlib_complex64_t z );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 5, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Left a few comments / suggestion, but overall this should be ready to land soon.

gururaj1512 and others added 4 commits November 11, 2024 20:29
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gururaj Gurram <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gururaj Gurram <[email protected]>
Signed-off-by: Gururaj Gurram <[email protected]>
Signed-off-by: Gururaj Gurram <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gururaj Gurram <[email protected]>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gururaj1512, for the edits! Will merge shortly.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Nov 11, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `math/base/special/croundf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/3061
Closes: https://github.com/stdlib-js/stdlib/issues/649

Co-authored-by: Gururaj Gurram <[email protected]>
Co-authored-by: Gururaj Gurram <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Gururaj Gurram <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit d9a93be into stdlib-js:develop Nov 11, 2024
17 checks passed
@gururaj1512 gururaj1512 deleted the croundf branch November 11, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementations to base special math functions (tracking issue)
3 participants