-
-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for math/base/special/avercos
#1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Snehil Shah <[email protected]>
Pranavchiku
suggested changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested minor changes.
lib/node_modules/@stdlib/math/base/special/avercos/test/test.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Pranav <[email protected]>
Signed-off-by: Pranav <[email protected]>
Pranavchiku
added
Feature
Issue or pull request for adding a new feature.
Math
Issue or pull request specific to math functionality.
C
Issue involves or relates to C.
Ready To Merge
A pull request which is ready to be merged.
labels
Mar 6, 2024
Pranavchiku
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, everything works. Thanks for this @Snehil-Shah !
Planeshifter
approved these changes
Mar 6, 2024
PoookieCoder
pushed a commit
to PoookieCoder/stdlib
that referenced
this pull request
Mar 7, 2024
PR-URL: stdlib-js#1719 Closes: stdlib-js#1714 --------- Signed-off-by: Snehil Shah <[email protected]> Signed-off-by: Pranav <[email protected]> Co-authored-by: Pranav <[email protected]> Reviewed-by: Pranav <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
nishant-s7
pushed a commit
to nishant-s7/stdlib
that referenced
this pull request
Mar 7, 2024
PR-URL: stdlib-js#1719 Closes: stdlib-js#1714 --------- Signed-off-by: Snehil Shah <[email protected]> Signed-off-by: Pranav <[email protected]> Co-authored-by: Pranav <[email protected]> Reviewed-by: Pranav <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C
Issue involves or relates to C.
Feature
Issue or pull request for adding a new feature.
Math
Issue or pull request specific to math functionality.
Ready To Merge
A pull request which is ready to be merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1714
Description
This pull request:
math/base/special/avercos
Related Issues
This pull request:
@stdlib/math/base/special/avercos
#1714Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers