Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/ellipe #1452

Merged
merged 50 commits into from
Mar 6, 2024
Merged

feat: add C implementation for math/base/special/ellipe #1452

merged 50 commits into from
Mar 6, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Mar 2, 2024 •
edited
Loading

Resolves #772

Description

Added C implementation for @stdlib/math/base/special/ellipe.

What is the purpose of this pull request?

This pull request:

  • adds c implementation for @stdlib/math/base/special/ellipe

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

gunjjoshi added 2 commits March 2, 2024 21:10
@gunjjoshi
feat: add C implementation for @stdlib/math/base/special/ellipe
fe2d39b 
This commit introduces a C implementation for the elliptic integral of the second kind (@stdlib/math/base/special/ellipe).
@gunjjoshi
feat: add C implementation for @stdlib/math/base/special/ellipe
c417c1e 
This commit introduces a C implementation for the elliptic integral of the second kind (@stdlib/math/base/special/ellipe).
@Planeshifter Planeshifter changed the title feat : add C implementation for @stdlib/math/base/special/ellipe feat: add C implementation for @stdlib/math/base/special/ellipe Mar 3, 2024
gunjjoshi added 23 commits March 3, 2024 11:06
@gunjjoshi
Update index.js
b747ddd 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update main.js
1265c52 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update poly_p1.js
cb4fe80 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update poly_p10.js
0292a30 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update poly_p11.js
305d517 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update README.md
5e596d5 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update poly_p12.js
32bec64 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update poly_p9.js
7bfad01 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update poly_p2.js
c9efb70 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update poly_p3.js
b63002f 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update poly_p4.js
e6fda42 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update poly_p5.js
17b6c55 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update poly_p6.js
1722c26 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update poly_p7.js
232bf8e 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update poly_p8.js
6d9f616 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
feat: add C implementation for @stdlib/math/base/special/ellipe
c52374e 
This commit introduces a C implementation for the elliptic integral of the second kind (@stdlib/math/base/special/ellipe).
@gunjjoshi
Revert "feat: add C implementation for @stdlib/math/base/special/ellipe"
95df2a4 
This reverts commit c52374e.
@gunjjoshi
Update evalpoly.js
9ea92bc 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Merge remote-tracking branch 'origin/ellipe-c' into ellipe-c
f104040
@gunjjoshi
feat: add C implementation for @stdlib/math/base/special/ellipe
7caf789 
This commit introduces a C implementation for the elliptic integral of the second kind (@stdlib/math/base/special/ellipe).
@gunjjoshi
Update README.md
aa6b465 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update README.md
62dbbe9 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update README.md
86be2c1 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi gunjjoshi marked this pull request as draft March 3, 2024 06:38
@gunjjoshi gunjjoshi marked this pull request as ready for review March 3, 2024 06:51
@gunjjoshi
Copy link
Member Author

This is ready for review now. @Pranavchiku

@gunjjoshi
Update include.gypi
8360e0c 
Signed-off-by: GUNJ JOSHI <[email protected]>
@Pranavchiku Pranavchiku added the Ready To Merge A pull request which is ready to be merged. label Mar 4, 2024
kgryte
kgryte requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gunjjoshi Thanks for working on this. We need to fix the indentation in a few files.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Ready To Merge A pull request which is ready to be merged. labels Mar 4, 2024
@gunjjoshi
Copy link
Member Author

@gunjjoshi Thanks for working on this. We need to fix the indentation in a few files.

I have made the changes suggested by you, along with fixing the indentation.

@kgryte kgryte added the Needs Review A pull request which needs code review. label Mar 5, 2024
kgryte
kgryte requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @gunjjoshi. Left a few more comments.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 6, 2024
gunjjoshi added 2 commits March 6, 2024 16:57
@gunjjoshi
Delete `lib/node_modules/@stdlib/math/base/special/ellipe/test/fixtur…
5d657df 
…es/cpp/large_negative.json`

Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Delete `lib/node_modules/@stdlib/math/base/special/ellipe/test/fixtur…
002500f 
…es/cpp/medium_negative.json`

Signed-off-by: GUNJ JOSHI <[email protected]>
kgryte
kgryte approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this now LGTM. Thanks, @gunjjoshi!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 6, 2024
@kgryte kgryte merged commit 23f2db6 into stdlib-js:develop Mar 6, 2024
7 checks passed
kgryte added a commit that referenced this pull request Mar 6, 2024
@kgryte
fix: update polynomial functions and fix function call
89da7ae 
Ref: #1452
@kgryte
Copy link
Member

kgryte commented Mar 6, 2024

Just an FYI: I had to push a patch due to bugs introduced in this PR: 89da7ae

For future PRs, be very careful about copying and pasting.

@gunjjoshi
Copy link
Member Author

Just an FYI: I had to push a patch due to bugs introduced in this PR: 89da7ae

For future PRs, be very careful about copying and pasting.

Definitely I'll keep that in mind. Apologies for this one. Thanks for correcting this.

PoookieCoder pushed a commit to PoookieCoder/stdlib that referenced this pull request Mar 7, 2024
@gunjjoshi @kgryte @Pranavchiku
feat: add C implementation for math/base/special/ellipe
54d4493 
Closes: stdlib-js#772
PR-URL: 	stdlib-js#1452
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Pranav Goswami <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Pranav Goswami <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: Pranav Goswami <[email protected]>
PoookieCoder pushed a commit to PoookieCoder/stdlib that referenced this pull request Mar 7, 2024
@kgryte
fix: update polynomial functions and fix function call
be018c2 
Ref: stdlib-js#1452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/ellipe
3 participants
@gunjjoshi @kgryte @Pranavchiku