Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore_: remove waku's type duplication #6264

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

osmaczko
Copy link
Contributor

@osmaczko osmaczko commented Jan 17, 2025

closes #6301

@status-im-auto
Copy link
Member

status-im-auto commented Jan 17, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ bcc22c3 #1 2025-01-17 09:52:44 ~4 min macos 📦zip
✔️ bcc22c3 #1 2025-01-17 09:52:52 ~4 min ios 📦zip
✔️ bcc22c3 #1 2025-01-17 09:53:37 ~5 min macos 📦zip
✔️ bcc22c3 #1 2025-01-17 09:53:41 ~5 min linux 📦zip
✔️ bcc22c3 #1 2025-01-17 09:53:47 ~5 min windows 📦zip
✔️ bcc22c3 #1 2025-01-17 09:54:23 ~6 min android 📦aar
✖️ bcc22c3 #1 2025-01-17 09:55:06 ~6 min tests-rpc 📄log
✔️ bcc22c3 #1 2025-01-17 10:19:27 ~31 min tests 📄log
✔️ bcc22c3 #2 2025-01-17 10:25:25 ~7 min tests-rpc 📄log

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 70.21277% with 14 lines in your changes missing coverage. Please review.

Project coverage is 61.54%. Comparing base (67134d9) to head (bcc22c3).
Report is 36 commits behind head on develop.

Files with missing lines Patch % Lines
wakuv2/api.go 71.42% 7 Missing and 1 partial ⚠️
wakuv1/api.go 69.23% 3 Missing and 1 partial ⚠️
waku/bridge/public_waku_api.go 66.66% 1 Missing ⚠️
waku/bridge/public_wakuv2_api.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6264      +/-   ##
===========================================
+ Coverage    61.52%   61.54%   +0.01%     
===========================================
  Files          842      842              
  Lines       110604   110539      -65     
===========================================
- Hits         68047    68026      -21     
+ Misses       34593    34562      -31     
+ Partials      7964     7951      -13     
Flag Coverage Δ
functional 21.50% <36.17%> (+<0.01%) ⬆️
unit 60.07% <70.21%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
waku/bridge/public_waku_api.go 36.84% <66.66%> (-21.06%) ⬇️
waku/bridge/public_wakuv2_api.go 36.84% <66.66%> (-19.77%) ⬇️
wakuv1/api.go 36.29% <69.23%> (ø)
wakuv2/api.go 38.26% <71.42%> (-0.31%) ⬇️

... and 31 files with indirect coverage changes

@osmaczko osmaczko requested a review from a team January 20, 2025 14:15
Copy link
Contributor

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osmaczko osmaczko merged commit b2bb680 into develop Jan 21, 2025
19 checks passed
@osmaczko osmaczko deleted the chore/remove-waku-duplicates branch January 21, 2025 07:20
@iurimatias iurimatias modified the milestone: 2.33.0 Beta Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove waku's type duplication
5 participants