fix(wallet)_: in case of sepolia optimism returned a nonce is not generated the same way as it is for optimism mainnet #6215
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
requested review from
alaibe,
shivekkhurana,
briansztamfater and
smohamedjavid
Jenkins BuildsClick to see older builds (8)
|
shivekkhurana
approved these changes
Dec 13, 2024
saledjenic
force-pushed
the
fix/sepolia-optimism-nonce
branch
from
3e165d0 to
5878311
Compare
…erated the same way as it is for optimism mainnet Changes done here simply increment the resolved nonce by sepolia optimism chain by one, cause it's differently generated that it is for mainnet sepolia and other chains. This change aligns on that.
saledjenic
force-pushed
the
fix/sepolia-optimism-nonce
branch
from
5878311 to
c212616
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6215 +/- ##
===========================================
+ Coverage 61.20% 61.23% +0.02%
===========================================
Files 833 833
Lines 109925 109927 +2
===========================================
+ Hits 67279 67311 +32
+ Misses 34772 34747 -25
+ Partials 7874 7869 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I would postpone merging this PR, cause what I've figured out these days is that sometimes nodefleet (the same as pokt before) is out of node sync and they return incorrect responses. At the time when I did this PR I didn't check other providers, but trusted to response and thought it's up to the chain. But if we look at the screenshots below and some checks I did, it looks like provider's issue. - nodefleet via Status Proxy - wrong Nonce returned - infura via StatusProcy - correct nonce - infura direct access - correct nonce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done here simply increment the resolved nonce by sepolia optimism chain by one, cause it's differently generated that it is for mainnet sepolia and other chains. This change aligns on that.