ci: upgrade go to 1.22 #17084
Draft
ci: upgrade go to 1.22 #17084
+59
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Jenkins BuildsClick to see older builds (145)
|
siddarthkay
force-pushed
the
upgrade-go-1-22
branch
from
7f62f15 to
1732ddd
Compare
jakubgs
requested changes
Jan 16, 2025
There was a problem hiding this comment.
You're missing Nix change:
status-desktop/nix/overlay.nix
Lines 40 to 41 in a7ae1a7
siddarthkay
force-pushed
the
upgrade-go-1-22
branch
2 times, most recently
from
822e686 to
2979b5d
Compare
jakubgs
approved these changes
Jan 16, 2025
siddarthkay
force-pushed
the
upgrade-go-1-22
branch
from
7be95ca to
6fd4a4b
Compare
siddarthkay
force-pushed
the
upgrade-go-1-22
branch
from
6fd4a4b to
d51083f
Compare
caybro
reviewed
Jan 27, 2025
ci/Jenkinsfile.macos
Outdated
| @@ -7,7 +7,7 @@ def isPRBuild = utils.isPRBuild() | |||
| pipeline { | |||
| /* This way we run the same Jenkinsfile on different platforms. */ | |||
| agent { | |||
| label "${getAgentLabels().join(' && ')} && qt-5.15 && go-1.21 && xcode-15.1" | |||
| label "${getAgentLabels().join(' && ')} && qt-5.15 && go-1.21 && xcode-16.1" | |||
There was a problem hiding this comment.
Suggested change
| label "${getAgentLabels().join(' && ')} && qt-5.15 && go-1.21 && xcode-16.1" | |
| label "${getAgentLabels().join(' && ')} && qt-5.15 && go-1.22 && xcode-16.1" |
There was a problem hiding this comment.
ah we don't have hosts with go 1.22 yet, I'm gonna upgrade them today and then do this.
Thanks for suggesting.
siddarthkay
force-pushed
the
upgrade-go-1-22
branch
from
f712f82 to
5682f20
Compare
siddarthkay
force-pushed
the
upgrade-go-1-22
branch
8 times, most recently
from
c2d83f0 to
bae15b1
Compare
siddarthkay
force-pushed
the
upgrade-go-1-22
branch
from
9038084 to
b9cda8c
Compare
siddarthkay
force-pushed
the
upgrade-go-1-22
branch
2 times, most recently
from
628e569 to
2927956
Compare
siddarthkay
force-pushed
the
upgrade-go-1-22
branch
from
2927956 to
33b065c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Todo