-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17069 wallet bring back mercuryo #17072
Conversation
Jenkins BuildsClick to see older builds (7)
|
@anastasiyaig Should we re-enable some squish tests as well? |
@alexjba we dont have any of them at the moment checking this providers. If that is making sense i could add one! |
Thanks! Just making sure |
Hi @alexjba I see two issues, I'm not sure if these were already present and have not been addressed or if this is something new. Could you take a look? Thanks! 1 - Assets load in an inconsistent way on the 'Buy via Mercuryo' screenOn the 'Buy via Mercuryo' screen, there is an inconsistence in the asset selection. The asset selector should show the list of the assets supported by Mercuryo https://exchange.mercuryo.io/ but when clicking on the 'Select asset' drop down, the complete list of supported assets does not show. If you change the network and change the assets, the available assets change. Screen.Recording.2025-01-15.at.2.57.24.PM.movFor example, choosing Arbitrum will bring only ETH But after changing network and changing the assets, if you go back to Arbitrum, more assets show. If the list of assets is incomplete and you try to search for a supported asset, no results are displayed. 2. There is no UI indication in the mercuryo site that a certain user account has been selected (not an issue on our end)As per this user story https://www.notion.so/Wallet-Buy-Mercuryo-0e7a1c954791441fb8ac190115d01a7a This AC says:
But when the user is directed to the Mercuryo site, the wallet address does not display. Should we update the user story? |
137f2cc
to
0b50bde
Compare
@virginiabalducci not sure how to get into the state where the assets list won't match the mercuryo supported assets. Screen.Recording.2025-01-20.at.14.44.28.mov |
Hi @alexjba Thanks for taking a look! What I see on my end is:
Result: Mainnet does not show the complete list of assets as step 3; instead, a limited list is shown. Screen.Recording.2025-01-21.at.10.58.56.AM.movIf you open the buy modal again, more assets show up, and others may not show. I'm attaching the console log as well in case it helps! Screen.Recording.2025-01-21.at.11.04.02.AM.movapp_20250121_103434.log Let me know if I can provide you with any further screenshot or file |
0b50bde
to
dc89cec
Compare
@virginiabalducci I've managed to reproduce and fixed it. Unfortunately the CI builds are down. Will ping you once it's green.
Indeed, there's no indication for the receiving account. The only indication I see is in the URL. Might be a good idea to do an E2E test for the buy to make sure the receiver account is correct and the funds are received. |
dc89cec
to
c547942
Compare
What does the PR do
Closes #17069
Needs status-im/status-go#6253
Revert "feat: hide mercuryo"
This reverts commit 22c4bb2.
This reverts commit status-im/status-go@4305609.