Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17069 wallet bring back mercuryo #17072

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented Jan 15, 2025

What does the PR do

Closes #17069
Needs status-im/status-go#6253

Revert "feat: hide mercuryo"

This reverts commit 22c4bb2.
This reverts commit status-im/status-go@4305609.

  • Adapt changes

@alexjba alexjba requested review from micieslak, a team and caybro as code owners January 15, 2025 08:19
@alexjba alexjba linked an issue Jan 15, 2025 that may be closed by this pull request
@alexjba alexjba requested review from Cuteivist, saledjenic and alaibe and removed request for a team January 15, 2025 08:19
@status-im-auto
Copy link
Member

status-im-auto commented Jan 15, 2025

Jenkins Builds

Click to see older builds (7)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 137f2cc #1 2025-01-15 08:27:03 ~7 min macos/aarch64 🍎dmg
✔️ 137f2cc #1 2025-01-15 08:29:12 ~9 min tests/nim 📄log
✔️ 137f2cc #1 2025-01-15 08:32:29 ~12 min tests/ui 📄log
✔️ 137f2cc #1 2025-01-15 08:35:28 ~15 min macos/x86_64 🍎dmg
✔️ 137f2cc #1 2025-01-15 08:40:11 ~20 min linux-nix/x86_64 📦tgz
✔️ 137f2cc #1 2025-01-15 08:41:25 ~21 min linux/x86_64 📦tgz
✔️ 137f2cc #1 2025-01-15 08:48:07 ~28 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
dc89cec #3 2025-01-24 10:20:51 ~4 min macos/aarch64 📄log
dc89cec #3 2025-01-24 10:21:23 ~5 min macos/x86_64 📄log
✔️ dc89cec #3 2025-01-24 10:25:43 ~9 min tests/nim 📄log
✔️ dc89cec #3 2025-01-24 10:28:35 ~12 min tests/ui 📄log
✔️ dc89cec #3 2025-01-24 10:34:50 ~18 min linux-nix/x86_64 📦tgz
✔️ dc89cec #3 2025-01-24 10:34:58 ~18 min linux/x86_64 📦tgz
✔️ dc89cec #3 2025-01-24 10:43:11 ~26 min windows/x86_64 💿exe
✔️ c547942 #4 2025-01-27 09:12:09 ~7 min tests/nim 📄log
✔️ c547942 #4 2025-01-27 09:12:18 ~7 min macos/aarch64 🍎dmg
✔️ c547942 #4 2025-01-27 09:16:13 ~11 min tests/ui 📄log
✔️ c547942 #4 2025-01-27 09:18:52 ~14 min macos/x86_64 🍎dmg
✔️ c547942 #4 2025-01-27 09:22:47 ~18 min linux-nix/x86_64 📦tgz
✔️ c547942 #4 2025-01-27 09:25:14 ~20 min linux/x86_64 📦tgz
✔️ c547942 #4 2025-01-27 09:29:38 ~24 min windows/x86_64 💿exe

@alexjba
Copy link
Contributor Author

alexjba commented Jan 15, 2025

@anastasiyaig Should we re-enable some squish tests as well?

@anastasiyaig
Copy link
Contributor

@alexjba we dont have any of them at the moment checking this providers. If that is making sense i could add one!

@alexjba
Copy link
Contributor Author

alexjba commented Jan 15, 2025

@alexjba we dont have any of them at the moment checking this providers. If that is making sense i could add one!

Thanks! Just making sure

@virginiabalducci
Copy link

virginiabalducci commented Jan 15, 2025

Hi @alexjba

I see two issues, I'm not sure if these were already present and have not been addressed or if this is something new. Could you take a look?

Thanks!

1 - Assets load in an inconsistent way on the 'Buy via Mercuryo' screen

On the 'Buy via Mercuryo' screen, there is an inconsistence in the asset selection. The asset selector should show the list of the assets supported by Mercuryo https://exchange.mercuryo.io/ but when clicking on the 'Select asset' drop down, the complete list of supported assets does not show. If you change the network and change the assets, the available assets change.

Screen.Recording.2025-01-15.at.2.57.24.PM.mov

For example, choosing Arbitrum will bring only ETH

Screenshot 2025-01-15 at 2 56 52 PM

But after changing network and changing the assets, if you go back to Arbitrum, more assets show.

Screenshot 2025-01-15 at 3 00 44 PM

If the list of assets is incomplete and you try to search for a supported asset, no results are displayed.
Screenshot 2025-01-15 at 3 02 07 PM

2. There is no UI indication in the mercuryo site that a certain user account has been selected (not an issue on our end)

As per this user story https://www.notion.so/Wallet-Buy-Mercuryo-0e7a1c954791441fb8ac190115d01a7a

This AC says:

Given Buy with Mercurio link is clicked
Then user is redirected to Mercurio website
And selected network+asset should be pre-selected
And the selected account's address should be pre-selected.

But when the user is directed to the Mercuryo site, the wallet address does not display. Should we update the user story?

Screenshot 2025-01-15 at 3 04 21 PM

@alexjba alexjba force-pushed the 17069-wallet-bring-back-mercuryo branch from 137f2cc to 0b50bde Compare January 20, 2025 12:47
@alexjba
Copy link
Contributor Author

alexjba commented Jan 20, 2025

@virginiabalducci not sure how to get into the state where the assets list won't match the mercuryo supported assets.
This is what I have and it's consistent with the token list found in Mercuryo website. It looks like the filtering is incorrect on your end. Are there some extra steps to take after login?

Screen.Recording.2025-01-20.at.14.44.28.mov
Screenshot 2025-01-20 at 14 41 31 Screenshot 2025-01-20 at 14 41 25

@virginiabalducci
Copy link

Hi @alexjba

Thanks for taking a look!

What I see on my end is:

  1. Open the Buy modal
  2. Select Mercuryo
  3. Mainnet is selected by default, click on Select asset and scroll the asset list
  4. Change network to Optimism and scroll assets
  5. Change network to Arbitrum and scroll assets
  6. Go back to Mainnet and scroll through the assets

Result: Mainnet does not show the complete list of assets as step 3; instead, a limited list is shown.
Notice also that Arbitrum network does not show the complete list of assets.

Screen.Recording.2025-01-21.at.10.58.56.AM.mov

If you open the buy modal again, more assets show up, and others may not show. I'm attaching the console log as well in case it helps!

Screen.Recording.2025-01-21.at.11.04.02.AM.mov

app_20250121_103434.log
app_20250121_105837.log

geth.log.zip

Let me know if I can provide you with any further screenshot or file

@alexjba alexjba force-pushed the 17069-wallet-bring-back-mercuryo branch from 0b50bde to dc89cec Compare January 24, 2025 10:16
@alexjba
Copy link
Contributor Author

alexjba commented Jan 24, 2025

@virginiabalducci I've managed to reproduce and fixed it. Unfortunately the CI builds are down. Will ping you once it's green.

  1. There is no UI indication in the mercuryo site that a certain user account has been selected (not an issue on our end)

Indeed, there's no indication for the receiving account. The only indication I see is in the URL. Might be a good idea to do an E2E test for the buy to make sure the receiver account is correct and the funds are received.

@anastasiyaig anastasiyaig force-pushed the 17069-wallet-bring-back-mercuryo branch from dc89cec to c547942 Compare January 27, 2025 09:04
@virginiabalducci
Copy link

Hey @alexjba

I tested the latest commit c547942 and I could verify that the issue with the available tokens is no longer reproducible ✅

@alexjba alexjba merged commit 2098300 into master Jan 27, 2025
9 checks passed
@alexjba alexjba deleted the 17069-wallet-bring-back-mercuryo branch January 27, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Wallet] Bring back Mercuryo
7 participants