-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate Base chain #17064
Merged
Merged
feat: integrate Base chain #17064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (54)
|
dlipicar
force-pushed
the
feat/integrate-base-chain
branch
4 times, most recently
from
January 14, 2025 13:12
8c24366
to
3e20a1e
Compare
dlipicar
requested review from
micieslak,
a team,
caybro and
alexjba
as code owners
January 14, 2025 16:40
dlipicar
requested review from
Cuteivist,
anastasiyaig and
Khushboo-dev-cpp
and removed request for
a team
January 14, 2025 16:40
dlipicar
force-pushed
the
feat/integrate-base-chain
branch
from
January 14, 2025 17:17
3e20a1e
to
564dce3
Compare
I was able to check the following areas:
I was not able to test the following:
This is an issue that is present in master. I created a bug to track this #17071 |
dlipicar
force-pushed
the
feat/integrate-base-chain
branch
from
January 15, 2025 11:58
564dce3
to
bbea7c8
Compare
caybro
reviewed
Jan 15, 2025
dlipicar
force-pushed
the
feat/integrate-base-chain
branch
2 times, most recently
from
January 16, 2025 13:07
04724e6
to
9cc0421
Compare
dlipicar
force-pushed
the
feat/integrate-base-chain
branch
from
January 20, 2025 17:02
9cc0421
to
c74a269
Compare
caybro
approved these changes
Jan 21, 2025
alaibe
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17070
What does the PR do
Add support for chains Base and Base Sepolia, Integrating status-go changes from status-im/status-go#6228
Affected areas
Wallet, Community Tokens.
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Screen.Recording.2025-01-14.at.13.38.25.mov