Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate Base chain #17064

Merged
merged 2 commits into from
Jan 21, 2025
Merged

feat: integrate Base chain #17064

merged 2 commits into from
Jan 21, 2025

Conversation

dlipicar
Copy link
Contributor

@dlipicar dlipicar commented Jan 13, 2025

Closes #17070

What does the PR do

Add support for chains Base and Base Sepolia, Integrating status-go changes from status-im/status-go#6228

Affected areas

Wallet, Community Tokens.

Architecture compliance

Screenshot of functionality (including design for comparison)

Screen.Recording.2025-01-14.at.13.38.25.mov
  • I've checked the design and this PR matches it

@status-im-auto
Copy link
Member

status-im-auto commented Jan 13, 2025

Jenkins Builds

Click to see older builds (54)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f69479d #1 2025-01-13 17:44:19 ~9 min macos/aarch64 🍎dmg
✔️ f69479d #1 2025-01-13 17:45:01 ~9 min tests/nim 📄log
✔️ f69479d #1 2025-01-13 17:47:06 ~11 min tests/ui 📄log
✔️ f69479d #1 2025-01-13 17:49:55 ~14 min macos/x86_64 🍎dmg
✔️ f69479d #1 2025-01-13 17:55:48 ~20 min linux-nix/x86_64 📦tgz
✔️ f69479d #1 2025-01-13 17:56:36 ~21 min linux/x86_64 📦tgz
✔️ f69479d #1 2025-01-13 17:59:09 ~23 min windows/x86_64 💿exe
✔️ ac38401 #2 2025-01-14 12:43:02 ~8 min tests/nim 📄log
✔️ ac38401 #2 2025-01-14 12:44:08 ~9 min macos/aarch64 🍎dmg
ac38401 #2 2025-01-14 12:47:46 ~13 min tests/ui 📄log
✔️ ac38401 #2 2025-01-14 12:49:26 ~15 min macos/x86_64 🍎dmg
✔️ ac38401 #2 2025-01-14 12:51:13 ~17 min linux-nix/x86_64 📦tgz
✔️ ac38401 #2 2025-01-14 12:52:45 ~18 min linux/x86_64 📦tgz
✔️ ac38401 #2 2025-01-14 12:57:05 ~22 min windows/x86_64 💿exe
✔️ 3e20a1e #5 2025-01-14 13:19:41 ~6 min macos/aarch64 🍎dmg
✔️ 3e20a1e #5 2025-01-14 13:20:43 ~7 min tests/nim 📄log
✔️ 3e20a1e #5 2025-01-14 13:24:11 ~11 min macos/x86_64 🍎dmg
✔️ 3e20a1e #5 2025-01-14 13:25:24 ~12 min tests/ui 📄log
✔️ 3e20a1e #5 2025-01-14 13:28:37 ~15 min linux-nix/x86_64 📦tgz
✔️ 3e20a1e #5 2025-01-14 13:31:39 ~18 min linux/x86_64 📦tgz
✔️ 3e20a1e #5 2025-01-14 13:33:51 ~20 min windows/x86_64 💿exe
✔️ 564dce3 #6 2025-01-14 17:23:33 ~5 min macos/aarch64 🍎dmg
✔️ 564dce3 #6 2025-01-14 17:27:13 ~9 min tests/nim 📄log
✔️ 564dce3 #6 2025-01-14 17:29:58 ~12 min tests/ui 📄log
✔️ 564dce3 #6 2025-01-14 17:30:31 ~12 min macos/x86_64 🍎dmg
✔️ 564dce3 #6 2025-01-14 17:35:43 ~17 min linux-nix/x86_64 📦tgz
✔️ 564dce3 #6 2025-01-14 17:37:45 ~19 min linux/x86_64 📦tgz
✔️ 564dce3 #6 2025-01-14 17:40:38 ~22 min windows/x86_64 💿exe
bbea7c8 #7 2025-01-15 12:03:33 ~4 min macos/aarch64 📄log
✔️ bbea7c8 #7 2025-01-15 12:07:41 ~8 min tests/nim 📄log
3919c43 #8 2025-01-15 12:09:55 ~2 min macos/aarch64 📄log
✔️ 3919c43 #8 2025-01-15 12:17:11 ~9 min tests/nim 📄log
✔️ 3919c43 #8 2025-01-15 12:20:37 ~12 min tests/ui 📄log
✔️ 3919c43 #8 2025-01-15 12:20:48 ~12 min macos/x86_64 🍎dmg
3919c43 #9 2025-01-15 12:24:19 ~2 min macos/aarch64 📄log
✔️ 3919c43 #8 2025-01-15 12:28:34 ~20 min linux-nix/x86_64 📦tgz
✔️ 3919c43 #8 2025-01-15 12:30:11 ~22 min linux/x86_64 📦tgz
✔️ 3919c43 #8 2025-01-15 12:31:53 ~23 min windows/x86_64 💿exe
3919c43 #10 2025-01-15 12:46:19 ~2 min macos/aarch64 📄log
3919c43 #11 2025-01-15 13:12:21 ~2 min macos/aarch64 📄log
3919c43 #12 2025-01-15 13:26:31 ~2 min macos/aarch64 📄log
3919c43 #13 2025-01-15 13:41:14 ~2 min macos/aarch64 📄log
3919c43 #14 2025-01-15 13:48:09 ~2 min macos/aarch64 📄log
3919c43 #15 2025-01-15 17:33:00 ~2 min macos/aarch64 📄log
3919c43 #16 2025-01-15 18:09:43 ~2 min macos/aarch64 📄log
3919c43 #17 2025-01-15 18:59:26 ~2 min macos/aarch64 📄log
3919c43 #18 2025-01-15 20:51:28 ~3 min macos/aarch64 📄log
04724e6 #19 2025-01-15 21:55:58 ~2 min macos/aarch64 📄log
✔️ 04724e6 #9 2025-01-15 22:02:55 ~9 min tests/nim 📄log
04724e6 #9 2025-01-15 22:05:32 ~12 min tests/ui 📄log
✔️ 04724e6 #9 2025-01-15 22:06:02 ~12 min macos/x86_64 🍎dmg
✔️ 04724e6 #9 2025-01-15 22:11:56 ~18 min linux-nix/x86_64 📦tgz
✔️ 04724e6 #9 2025-01-15 22:13:02 ~19 min linux/x86_64 📦tgz
✔️ 04724e6 #9 2025-01-15 22:17:11 ~23 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9cc0421 #20 2025-01-16 13:13:46 ~5 min macos/aarch64 🍎dmg
✔️ 9cc0421 #10 2025-01-16 13:16:54 ~8 min tests/nim 📄log
✔️ 9cc0421 #10 2025-01-16 13:20:16 ~12 min tests/ui 📄log
✔️ 9cc0421 #10 2025-01-16 13:21:00 ~12 min macos/x86_64 🍎dmg
✔️ 9cc0421 #10 2025-01-16 13:26:41 ~18 min linux/x86_64 📦tgz
✔️ 9cc0421 #10 2025-01-16 13:33:12 ~24 min linux-nix/x86_64 📦tgz
✔️ 9cc0421 #10 2025-01-16 13:33:55 ~25 min windows/x86_64 💿exe
✔️ c74a269 #21 2025-01-20 17:10:44 ~7 min macos/aarch64 🍎dmg
✔️ c74a269 #11 2025-01-20 17:12:11 ~9 min tests/nim 📄log
✔️ c74a269 #11 2025-01-20 17:14:48 ~12 min tests/ui 📄log
✔️ c74a269 #11 2025-01-20 17:15:53 ~13 min macos/x86_64 🍎dmg
✔️ c74a269 #11 2025-01-20 17:22:10 ~19 min linux/x86_64 📦tgz
✔️ c74a269 #11 2025-01-20 17:25:49 ~22 min windows/x86_64 💿exe

@dlipicar dlipicar force-pushed the feat/integrate-base-chain branch 4 times, most recently from 8c24366 to 3e20a1e Compare January 14, 2025 13:12
@dlipicar dlipicar marked this pull request as ready for review January 14, 2025 16:40
@dlipicar dlipicar requested review from micieslak, a team, caybro and alexjba as code owners January 14, 2025 16:40
@dlipicar dlipicar requested review from Cuteivist, anastasiyaig and Khushboo-dev-cpp and removed request for a team January 14, 2025 16:40
@virginiabalducci virginiabalducci self-requested a review January 14, 2025 16:50
@dlipicar dlipicar force-pushed the feat/integrate-base-chain branch from 3e20a1e to 564dce3 Compare January 14, 2025 17:17
@virginiabalducci
Copy link

virginiabalducci commented Jan 14, 2025

I was able to check the following areas:

  • Network dropdown, icon in mainnet, testnet
  • Send and Swap Modal: icon in mainnet and testnet
  • Can send Base eth in testnet and mainnet
  • Can receive Base eth in testnet and mainnet
  • Can see Base in the Settings -> Wallet -> Network
  • Can switch between Testnet and Mainnet
  • Can edit settings of Base network
  • Can create a community and mint Owner and TokenMaster
  • Bridge from L1 to Base (via Browser connect) in both testnet and mainnet
  • Send and receive Base SNT
  • Swap Base ETH for ERC20

I was not able to test the following:

  • Airdrop
  • Mint token

This is an issue that is present in master. I created a bug to track this #17071

@dlipicar dlipicar force-pushed the feat/integrate-base-chain branch from 564dce3 to bbea7c8 Compare January 15, 2025 11:58
@dlipicar dlipicar force-pushed the feat/integrate-base-chain branch 2 times, most recently from 04724e6 to 9cc0421 Compare January 16, 2025 13:07
@dlipicar dlipicar force-pushed the feat/integrate-base-chain branch from 9cc0421 to c74a269 Compare January 20, 2025 17:02
@status-im-auto
Copy link
Member

@dlipicar dlipicar merged commit b3ecaba into master Jan 21, 2025
9 checks passed
@dlipicar dlipicar deleted the feat/integrate-base-chain branch January 21, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Base chain
5 participants