feat(onboarding): hook metrics to the new onboarding #17058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
micieslak,
caybro,
alexjba and
a team
as code owners
Jenkins BuildsClick to see older builds (62)
|
jrainville
force-pushed
the
feat/new-onbaording-integration
branch
from
77b5d44 to
bb284bd
Compare
jrainville
requested review from
dlipicar and
glitchminer
and removed request for
a team
jrainville
force-pushed
the
feat/new-onboarding-metrics
branch
from
dbedf7a to
d2d7fe9
Compare
4 tasks
jrainville
force-pushed
the
feat/new-onbaording-integration
branch
from
bb284bd to
5b2d30f
Compare
jrainville
force-pushed
the
feat/new-onboarding-metrics
branch
from
d2d7fe9 to
0e412d4
Compare
4 tasks
jrainville
force-pushed
the
feat/new-onboarding-metrics
branch
from
0e412d4 to
aa5321c
Compare
jrainville
force-pushed
the
feat/new-onbaording-integration
branch
from
3a0e9b9 to
c13a96b
Compare
glitchminer
approved these changes
Jan 21, 2025
jrainville
force-pushed
the
feat/new-onbaording-integration
branch
from
c13a96b to
8537b0a
Compare
jrainville
force-pushed
the
feat/new-onboarding-metrics
branch
3 times, most recently
from
35bea58 to
668777f
Compare
caybro
approved these changes
Jan 24, 2025
| else | ||
| stack.push(loginScreenComponent) | ||
| onboardingFlow.init() | ||
| // if (loginAccountsModel.ModelCount.empty) |
There was a problem hiding this comment.
You could keep this in 🤔 or just invert the condition:
Suggested change
| // if (loginAccountsModel.ModelCount.empty) | |
| if (!!loginAccountsModel && !loginAccountsModel.ModelCount.empty) | |
| stack.push(loginScreenComponent) | |
| else | |
| onboardingFlow.init() |
| @@ -35,6 +37,7 @@ type | |||
| viewVariant: QVariant | |||
| controller: Controller | |||
| localPairingStatus: LocalPairingStatus | |||
| currentFlow: SecondaryFlow | |||
There was a problem hiding this comment.
I think you can rename it here in NIM to sth like OnboardingFlow; I'll do the same in enums.h but I think it'd be nice to actually use the one from enums.h
micieslak
reviewed
Jan 24, 2025
jrainville
force-pushed
the
feat/new-onboarding-metrics
branch
from
668777f to
b14dcf3
Compare
|
@caybro @micieslak I addressed your comments. It's way smaller and cleaner now |
micieslak
reviewed
Jan 24, 2025
There was a problem hiding this comment.
There is one problem regarding InspectionUtils::baseName move.
Generally, Storybook is intended to be independent from the application code. Only hosted pages should use app's functionality. By using utils we start mixing those two areas. In inspection utils the function is quite specific for needs of inspection itself. In the app I would use a bit altered version:
function objectTypeName(item) {
let typeName = item.toString()
if (typeName.startsWith("QQuick"))
typeName = name.substring(6)
const underscoreIndex = typeName.indexOf("_")
if (underscoreIndex !== -1)
return typeName.substring(0, underscoreIndex)
const bracketIndex = typeName.indexOf("(")
if (bracketIndex !== -1)
return typeName.substring(0, bracketIndex)
return typeName
}Because of that I would opt for just copying the function to Utils.qml, under more descriptive name, maybe objectTypeName.
At some point in the future we can consider excluding some small "core" library to be shared among storybook app and the status-desktop app itself.
jrainville
force-pushed
the
feat/new-onboarding-metrics
branch
from
b14dcf3 to
344d28f
Compare
|
@micieslak gotcha. Fixed |
4 tasks
|
The tests passed but the report failed Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #17047
Hooks the same old metrics we had previously to the new onboarding.
The only difference is we cannot easily track the flow during page navigation because the flow is often jsut sent at the end. Anyway, I think mobile also doesn't give it and it's easy to infer the flow from the page name.
I added a required property to the OnboardinPages so that we cna get the page name and send it. If it's not set on some page, we just don't send a metric.
Affected areas
Onboarding metrics
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Impact on end user
None, it works as before
How to test
messageType=AsyncAddCentralizedMetricIfEnabledTaskArg.Risk
Tick one:
The only difference is the pages are not named the same as before, but that's expected since we changed the whole design.