WIP feat(Onboarding) Implement new Login screen #17057
Draft
+1,828
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
2 times, most recently
from
544dd34 to
f6b898d
Compare
Jenkins BuildsClick to see older builds (128)
|
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
f6b898d to
7be9676
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
7be9676 to
401e2e0
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
401e2e0 to
b688aae
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
b688aae to
c263dfc
Compare
micieslak
force-pushed
the
feat/onboarding-rework-1
branch
2 times, most recently
from
d5524fd to
35b8620
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
c263dfc to
73ddd3b
Compare
anastasiyaig
force-pushed
the
feat/onboarding-rework-1
branch
from
29ce4b0 to
43a5b68
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
73ddd3b to
0557b49
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
0557b49 to
a9fecc4
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
a9fecc4 to
5e00603
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
5e00603 to
589e17c
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
589e17c to
0157c62
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
0157c62 to
e788759
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
e788759 to
8f2112d
Compare
- explicitely provide a bg color - also fix the mouse cursor shape
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
8f2112d to
3d87833
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
3d87833 to
bf1d7e1
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
bf1d7e1 to
6ae95f6
Compare
jrainville
reviewed
Jan 17, 2025
| @@ -226,9 +229,15 @@ Item { | |||
|
|
|||
| // Some component validations: | |||
| if(text.length !== d.currentPinIndex) | |||
| console.error("StatusPinInput input management error. Current pin length must be "+ text.length + "and is " + d.currentPinIndex) | |||
| console.error("StatusPinInput input management error. Current pin length must be "+ text.length + " and is " + d.currentPinIndex) | |||
There was a problem hiding this comment.
Does QML support strings using backticks?
If so, this would be cleaner:
Suggested change
| console.error("StatusPinInput input management error. Current pin length must be "+ text.length + " and is " + d.currentPinIndex) | |
| console.error(`StatusPinInput input management error. Current pin length must be ${text.length} and is ${ d.currentPinIndex}`) |
There was a problem hiding this comment.
Yeah it does; existing code so didn't touch it more than I wanted :)
| required property var loginAccountsModel | ||
|
|
||
| property bool biometricsAvailable: Qt.platform.os === Constants.mac | ||
| required property bool isBiometricsLogin // FIXME should come from the loginAccountsModel for each profile separately? |
There was a problem hiding this comment.
I just checked and indeed, it is per account because it comes from localAccountSettings and it changes depending on the selected profile
proc setSelectedLoginAccount*(self: Controller, keyUid: string, isKeycardAccount: bool) =
...
let selectedAccount = self.getSelectedLoginAccount()
singletonInstance.localAccountSettings.setFileName(selectedAccount.name)There was a problem hiding this comment.
But wtf... how can this work when we are not logged in yet 🤔
Currently it's evaluated based on:
isBiometricsLogin: localAccountSettings.storeToKeychainValue === Constants.keychain.storedValue.storelocalAccountSettings
There was a problem hiding this comment.
I mean, in the context of the login screen, this doesn't make sense, as we are not logged in yet
There was a problem hiding this comment.
This settings are not encrypted. It's what you can find in Status/qt. sensitive_settings are the settings for when you are logged in
There was a problem hiding this comment.
This settings are not encrypted. It's what you can find in
Status/qt.sensitive_settingsare the settings for when you are logged in
Ok, but how does the particular setting get associated with another profile (one that's not yet logged in)?
| image: model.thumbnailImage | ||
| colorId: model.colorId | ||
| colorHash: model.colorHash | ||
| // keycardLocked // FIXME needed here too? should be coming from the model imo |
There was a problem hiding this comment.
What happens if this is set to true? Does it mean that it uses a keycard or that the keycard is locked?
There was a problem hiding this comment.
The latter, we can arrive there after too many failed PIN attempts
There was a problem hiding this comment.
But I verified with Ben that it's not needed in the combo (that keycard may not be inserted yet); will remove
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
6ae95f6 to
3e8ee44
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
3e8ee44 to
bb03c20
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
bb03c20 to
740cdcb
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
740cdcb to
f9242cd
Compare
caybro
force-pushed
the
feat/onboarding-new-login-screen
branch
from
f9242cd to
8eed24e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
TODO:
Fixes #17049
Fixes #17081
Affected areas
Login screen
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)