feat(Post Onboarding): Introduce yourself popup #17044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
force-pushed
the
17027-post-onboarding-introduce-yourself
branch
from
658f794 to
4b27cfb
Compare
Jenkins BuildsClick to see older builds (14)
|
4 tasks
caybro
force-pushed
the
17027-post-onboarding-introduce-yourself
branch
2 times, most recently
from
df4f12e to
5842678
Compare
- popup displayed only ever once - triggered when section is switched to anything else than wallet (default for new users) or settings (profile visible first anyway) - add the popup to SB Fixes #17027
caybro
force-pushed
the
17027-post-onboarding-introduce-yourself
branch
from
5842678 to
dd37efd
Compare
caybro
requested review from
jrainville and
igor-sirotin
and removed request for
a team
jrainville
approved these changes
Jan 29, 2025
| onCurrentIndexChanged: { | ||
| const sectionType = appMain.rootStore.mainModuleInst.activeSection.sectionType | ||
| if (sectionType !== Constants.appSection.profile && sectionType !== Constants.appSection.wallet) { | ||
| d.maybeDisplayIntroduceYourselfPopup() |
There was a problem hiding this comment.
Since maybeDisplayIntroduceYourselfPopup is only used once, I'd feel fine moving its code here
micieslak
approved these changes
Jan 30, 2025
| import QtQuick 2.15 | ||
| import QtQuick.Controls 2.15 | ||
|
|
||
| import Storybook 1.0 |
| IntroduceYourselfPopup { | ||
| id: popup | ||
| visible: true | ||
| closePolicy: Popup.NoAutoClose |
There was a problem hiding this comment.
for consistency: anchors.centerIn: parent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #17027
Affected areas
AppMain
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Zaznam.obrazovky.z.2025-01-09.20-38-36.mp4