feat(dapps): Adding dapp metrics #16962

alexjba · 2024-12-13T13:38:46Z

What does the PR do

Sending the dapps events to mixpanel

Events structure: https://www.notion.so/Event-Tracking-Specification-Desktop-1518f96fb65c8026a3a5c8a0459f7f21?pvs=4#63de5b7c3b6c4a7cab492cff6aa95957

Events description: https://www.notion.so/Metrics-for-Wallet-Connect-d3d1e60e7ea24479bd35cbb11219540c?pvs=4#375a52965a98458eb45b2e2eea6a4bd5

New board created here: https://eu.mixpanel.com/s/3kYRpk

Moved the Connect dialog from dapps comboBox to the dappsWorkflow where the other modals are placed
Extend component with necessary signals/functions of collect metrics data
Update tests and storybook
Implement fully functional storybook metrics page to test the events with Mixpanel

Affected areas

dapps

Architecture compliance

I am familiar with the application architecture and agreed good practices.
My PR is consistent with this document: Status Desktop Architecture Guide

status-im-auto · 2024-12-13T13:45:37Z

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`591ba99`	#1	2024-12-13 13:45:37	~6 min	`macos/aarch64`	🍎`dmg`
✔️	`591ba99`	#1	2024-12-13 13:46:56	~7 min	`tests/nim`	📄`log`
❌	`591ba99`	#1	2024-12-13 13:51:38	~12 min	`tests/ui`	📄`log`
✔️	`591ba99`	#1	2024-12-13 13:55:27	~16 min	`linux-nix/x86_64`	📦`tgz`
✔️	`591ba99`	#1	2024-12-13 13:57:21	~18 min	`macos/x86_64`	🍎`dmg`
✔️	`591ba99`	#1	2024-12-13 14:01:06	~22 min	`linux/x86_64`	📦`tgz`
✔️	`591ba99`	#1	2024-12-13 14:01:41	~22 min	`windows/x86_64`	💿`exe`
❌	`591ba99`	#2	2024-12-18 13:06:56	~12 min	`tests/ui`	📄`log`

✔️	`f32b9bb`	#2	2025-01-10 10:48:52	~9 min	`macos/aarch64`	🍎`dmg`
✔️	`f32b9bb`	#2	2025-01-10 10:48:58	~9 min	`tests/nim`	📄`log`
✔️	`f32b9bb`	#3	2025-01-10 10:51:54	~12 min	`tests/ui`	📄`log`
✔️	`f32b9bb`	#2	2025-01-10 10:53:18	~13 min	`macos/x86_64`	🍎`dmg`
✔️	`f32b9bb`	#2	2025-01-10 10:58:33	~18 min	`linux/x86_64`	📦`tgz`
✔️	`f32b9bb`	#2	2025-01-10 10:59:54	~20 min	`linux-nix/x86_64`	📦`tgz`
✔️	`f32b9bb`	#2	2025-01-10 11:03:36	~23 min	`windows/x86_64`	💿`exe`

Cuteivist

LGTM

caybro

Wow, massive work 💯

Just got a question regarding enabling stuff by default

caybro · 2024-12-18T10:30:45Z

ui/app/AppLayouts/Wallet/panels/WalletHeader.qml

@@ -36,12 +36,10 @@ Item {

    property bool dAppsEnabled: true
    property bool dAppsVisible: true
-    property bool walletConnectEnabled: true
-    property bool browserConnectEnabled: true


No longer needed?

no longer needed here. The reason is that I've moved the connect popups living in DappsComboBox.qml (the dapps button found in the header) in the DAppsWorkflow where the other dapps popups are implemented. These flags were needed for the connect popups.

caybro · 2024-12-18T10:31:10Z

ui/app/AppLayouts/Wallet/popups/dapps/DAppsWorkflow.qml

@@ -77,6 +83,9 @@ SQUtils.QObject {

    property var formatBigNumber: (number, symbol, noSymbolOption) => console.error("formatBigNumber not set")

+    property bool walletConnectEnabled: true
+    property bool connectorEnabled: true


Unconditionally on now?

the default is true. But the proper value is set in the AppMain, depending on the feature flags.

caybro

Nice work

virginiabalducci · 2024-12-23T16:04:41Z

I tested the metrics and they all work good except for:

flow=sign_received : a new sign/transaction request is accepted, method: eth_signTransaction: I cannot accept eth_signTransactions, when I try to sign them they get rejected
I tested this on these dApps:
https://metamask.github.io/test-dapp/
https://se-sdk-dapp.vercel.app/

I can't yet trigger these, I'm not sure if I don't know how to trigger them yet, or if it's really a bug.
wc-unavailable: I tried disabling both WC and BC flags and nothing happens. I'm unsure if there is any API or network call that can be blocked to trigger this.
wc-available : I believe this should trigger by default if WC - BC are enabled, but this is not happening.

closes #16912 Sending the dapps events to mixpanel | Event Name | Properties | Possible Values | Notes | | --- | --- | --- | --- | | dapps-health | state | - wc_available - wc_unavailable - chains_down - network_down - pair_error - connection_error - sign_error | | | | error | | string description | | dapps-navigation | flow | - dapps_list_opened - connect_initiated - disconnect_initiated - pair_initiated | | | | connector | - wallet_connect - browser_connect | | | dapps-connection | flow | - proposal_received - proposal_accepted - proposal_rejected - connected - disconnected | | | | networks | networks[string] - array of networks | Array of proposed or connected networks | | | methods | methods[string] - array of methods | Array of proposed methods | | | dapp | dapp uri | | | | connector | - wallet_connect - browser_connect | | | | isSiwe | boolean | | | dapps-sign | flow | - sign_received - sign_accepted - sign_rejected | | | | connector | - wallet_connect - browser_connect | | | | method | - personal_sign - eth_sign - eth_signTypedData_v4 - eth_signTypedData - eth_signTransaction - eth_sendTransaction | | | | dapp | string - dapp uri | | | | chainId | int - chain id | |

alexjba · 2025-01-10T10:38:21Z

I tested the metrics and they all work good except for:

flow=sign_received : a new sign/transaction request is accepted, method: eth_signTransaction: I cannot accept eth_signTransactions, when I try to sign them they get rejected I tested this on these dApps: https://metamask.github.io/test-dapp/ https://se-sdk-dapp.vercel.app/

For now we only support personalSign, sign, signTypedData_v4, signTypedData, sendTransaction.
It will be nice to implement the signTransaction at some point, but not sure when. There is this task for it
#16770 (comment)

I can't yet trigger these, I'm not sure if I don't know how to trigger them yet, or if it's really a bug. wc-unavailable: I tried disabling both WC and BC flags and nothing happens. I'm unsure if there is any API or network call that can be blocked to trigger this. wc-available : I believe this should trigger by default if WC - BC are enabled, but this is not happening.

wc-available seems to be triggered on every startup when the app successfully initiated the WC sdk.

wc-unavailable is still a mystery to me as well. I've tried to play around with identifying and blocking some WC IPs, but it still works. There's a report from @anastasiyaig where WC cannot be initialized on some VPNs and this event should catch it. That's the purpose of it. @anastasiyaig Is it possible for you to test this build with your VPN where the WC sdk cannot be initialized?

virginiabalducci · 2025-01-13T14:44:42Z

Edit:
I am able to see wc-available on accounts that have the metric collection enabled.

when this is toggled off, the wc-available metric does not trigger and this is the correct behavior

alexjba · 2025-01-13T16:51:29Z

Edit: I am able to see wc-available on accounts that have the metric collection enabled.

when this is toggled off, the wc-available metric does not trigger and this is the correct behavior

nice! This means the only point to validate is the wc-unavailable?

virginiabalducci · 2025-01-13T17:50:54Z

Edit: I am able to see wc-available on accounts that have the metric collection enabled.
when this is toggled off, the wc-available metric does not trigger and this is the correct behavior

nice! This means the only point to validate is the wc-unavailable?

yes correct!

anastasiyaig · 2025-01-14T11:29:05Z

gonna check it now

anastasiyaig · 2025-01-14T12:23:17Z

i did my best to reproduce it but i could not sadly :(

alexjba requested review from micieslak, a team and caybro as code owners December 13, 2024 13:38

alexjba requested review from Cuteivist, Khushboo-dev-cpp, alaibe and saledjenic and removed request for a team December 13, 2024 13:38

alexjba assigned alexjba, virginiabalducci and anastasiyaig and unassigned alexjba Dec 13, 2024

Cuteivist approved these changes Dec 18, 2024

View reviewed changes

caybro reviewed Dec 18, 2024

View reviewed changes

caybro approved these changes Dec 18, 2024

View reviewed changes

alexjba force-pushed the feat/dapps-metrics branch from 591ba99 to f32b9bb Compare January 10, 2025 10:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dapps): Adding dapp metrics #16962

feat(dapps): Adding dapp metrics #16962

alexjba commented Dec 13, 2024

status-im-auto commented Dec 13, 2024 •

edited

Loading

Cuteivist left a comment

caybro left a comment

caybro Dec 18, 2024

alexjba Dec 18, 2024

caybro Dec 18, 2024

alexjba Dec 18, 2024

caybro left a comment

virginiabalducci commented Dec 23, 2024

alexjba commented Jan 10, 2025

virginiabalducci commented Jan 13, 2025 •

edited

Loading

alexjba commented Jan 13, 2025

virginiabalducci commented Jan 13, 2025

anastasiyaig commented Jan 14, 2025

anastasiyaig commented Jan 14, 2025

feat(dapps): Adding dapp metrics #16962

Are you sure you want to change the base?

feat(dapps): Adding dapp metrics #16962

Conversation

alexjba commented Dec 13, 2024

What does the PR do

Affected areas

Architecture compliance

status-im-auto commented Dec 13, 2024 • edited Loading

Jenkins Builds

Cuteivist left a comment

Choose a reason for hiding this comment

caybro left a comment

Choose a reason for hiding this comment

caybro Dec 18, 2024

Choose a reason for hiding this comment

alexjba Dec 18, 2024

Choose a reason for hiding this comment

caybro Dec 18, 2024

Choose a reason for hiding this comment

alexjba Dec 18, 2024

Choose a reason for hiding this comment

caybro left a comment

Choose a reason for hiding this comment

virginiabalducci commented Dec 23, 2024

alexjba commented Jan 10, 2025

virginiabalducci commented Jan 13, 2025 • edited Loading

alexjba commented Jan 13, 2025

virginiabalducci commented Jan 13, 2025

anastasiyaig commented Jan 14, 2025

anastasiyaig commented Jan 14, 2025

status-im-auto commented Dec 13, 2024 •

edited

Loading

virginiabalducci commented Jan 13, 2025 •

edited

Loading