fix(community): fix community image not updating #16807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
micieslak,
caybro,
alexjba and
a team
as code owners
Jenkins BuildsClick to see older builds (10)
|
caybro
approved these changes
Nov 25, 2024
Agreed. I created a new issue for it: #16814 |
alexjba
approved these changes
Nov 27, 2024
jrainville
force-pushed
the
fix/community-image-not-updating-2
branch
from
856fede to
20ee8d5
Compare
jrainville
force-pushed
the
fix/community-image-not-updating-2
branch
from
20ee8d5 to
481016f
Compare
Fixes #16688 Fixes the issue by adding a version to the URL on the status-go side. No extra code needed on our side. The only change is that we no longer need the `addTimestampToURL` hack for the community now.
jrainville
force-pushed
the
fix/community-image-not-updating-2
branch
from
481016f to
69aa3f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #16688
Fixes the issue by adding a version to the URL on the status-go side. No extra code needed on our side. The only change is that we no longer need the
addTimestampToURLhack for the community now.Status-go PR: status-im/status-go#6118
Affected areas
Community image url
Screenshot of functionality (including design for comparison)
edit-img.webm
Note that the app on the right is on master, hence why it still has the issue
Impact on end user
Updated image will show straight away
How to test
Risk
Tick one:
Worst case: the bug still happens