Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor contact images to use a "version" in the local URL to avoid using the addTimestampToURL hack #16814

Open
jrainville opened this issue Nov 25, 2024 · 1 comment · May be fixed by #17054
Assignees
Milestone

Comments

@jrainville
Copy link
Member

Description

Currently, the contact images come from the local image server spun by status-go. This is great because it saves memory for images.

However, it makes it so that the image URL is always the same. Something like https://Localhost:46739/contactImages?publicKey=0x03c5ece7da362d31199fb02d632f85fdf853af57d89c3204b4d1e90c6ec13bb23c&imageName=thumbnail
So when the image gets updated in the DB, we get a signal from status-go that the contact got updated, but the URL is the same, so the comparison we do for the contact properties doesn't trigger an update (dataChanged).

The solution for that is to do similarly to this change done for communities, ie add a version query param:

Acceptance criteria

  • addTimestampToURL is removed from the code
  • Contact images update for ourselves and when others change it correctly, ie we don't need to restart the app to see the update.
@jrainville
Copy link
Member Author

Starting work on this because the status-go part was fixed by @seanstrom here status-im/status-go#6239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Code Review
Development

Successfully merging a pull request may close this issue.

2 participants