Refresh endians2 #160
Merged
Refresh endians2 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* speed up conversions by unrolling bulk limb conversion * remove default from `toBytes`/`fromBytes` - the existing default did not match `stew/endians2` which is an unnecessary risk - rather than changing it to match, the safer option is to remove it for now so that code in the wild gets a compile error * deprecate redundant names like `toByteArrayXX` (`toBytesXX` etc do the same thing) * deprecate staticFor (now lives in stew)
some weird 1.6 error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toBytes/fromBytes- the existing default did not matchstew/endians2which is an unnecessary risk - rather than changing it to match, the safer option is to remove it for now so that code in the wild gets a compile errortoByteArrayXX(toBytesXXetc do the same thing)