Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: 1:1 between MR and infra for ID fields #115

Merged
merged 2 commits into from
Jan 15, 2025
Merged

chore!: 1:1 between MR and infra for ID fields #115

merged 2 commits into from
Jan 15, 2025

Conversation

tenstad
Copy link
Member

@tenstad tenstad commented Jan 15, 2025

Should these be ...Id as that is the conect of the infra resource?

Open for closing this, just wanna raise the question.

@tenstad tenstad requested a review from erikgb January 15, 2025 13:48
@tenstad
Copy link
Member Author

tenstad commented Jan 15, 2025

Hmmm, seems the convention is actually Id on all fields, at least according to https://github.com/crossplane/crossplane/blob/5ce2f115f2653e29fb9b1cf501439403bda5c675/design/one-pager-cross-resource-referencing.md?plain=1#L176 and https://github.com/crossplane/crossplane issue 707

So it's not a ref to the Kind, but a technical ref to the actual field, weird 🤔

Wouldn't it be more intuitive to reference the managed resource, and use the name of the Kind. Especially as the ref has a name. Having userIdRef, the name is not for the userId, but for the User (kind).

@tenstad tenstad merged commit 445e881 into main Jan 15, 2025
6 checks passed
@tenstad tenstad deleted the id branch January 15, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants