Add PcsConfig to CommitmentSchemeProof

[alon-f]

No description provided.

[reviewable-StarkWare]

This change is 

[alon-f]

• Add security_bites function to PcsConfig #998
• Add PcsConfig to CommitmentSchemeProof #996 👈 (View in Graphite)
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.89%. Comparing base (438c107) to head (7badc8b).
Report is 1 commits behind head on dev.

Files with missing lines	Patch %	Lines
crates/prover/src/core/prover/mod.rs	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #996      +/-   ##
==========================================
+ Coverage   92.27%   92.89%   +0.61%     
==========================================
  Files         105      105              
  Lines       14221    14247      +26     
  Branches    14221    14247      +26     
==========================================
+ Hits        13123    13235     +112     
+ Misses       1024      933      -91     
- Partials       74       79       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andrewmilson]

Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion (waiting on @alon-f, @ilyalesokhin-starkware, and @shaharsamocha7)

---

crates/prover/src/examples/blake/air.rs line 505 at r2 (raw file):

#[allow(unused)]
pub fn verify_blake<MC: MerkleChannel>(

We need to check the security somewhere.
If not in this PR can we add a TODO plz

[shaharsamocha7]

Reviewed 9 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @alon-f, @andrewmilson, and @ilyalesokhin-starkware)

---

crates/prover/src/examples/blake/air.rs line 505 at r2 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

We need to check the security somewhere.
If not in this PR can we add a TODO plz

Agree with Andrew, we should have that check both in the rust/cairo verifiers.
Please add this TODO

---

crates/prover/src/examples/poseidon/mod.rs line 510 at r2 (raw file):

        let channel = &mut Blake2sChannel::default();
        let commitment_scheme =
            &mut CommitmentSchemeVerifier::<Blake2sMerkleChannel>::new(proof.config);

I think that you can put the check security bits here as an example

Code quote:

        let commitment_scheme =
            &mut CommitmentSchemeVerifier::<Blake2sMerkleChannel>::new(proof.config);

---

crates/prover/src/core/pcs/mod.rs line 21 at r2 (raw file):

pub use self::verifier::CommitmentSchemeVerifier;
use super::fri::FriConfig;

Re-add this empty line

[alon-f]

Reviewable status: 9 of 10 files reviewed, 3 unresolved discussions (waiting on @andrewmilson, @ilyalesokhin-starkware, and @shaharsamocha7)

---

crates/prover/src/core/pcs/mod.rs line 21 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Re-add this empty line

Done.

[alon-f]

Reviewable status: 9 of 10 files reviewed, 3 unresolved discussions (waiting on @andrewmilson, @ilyalesokhin-starkware, and @shaharsamocha7)

---

crates/prover/src/examples/blake/air.rs line 505 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Agree with Andrew, we should have that check both in the rust/cairo verifiers.
Please add this TODO

Done.

---

crates/prover/src/examples/poseidon/mod.rs line 510 at r2 (raw file):

Previously, shaharsamocha7 wrote…

I think that you can put the check security bits here as an example

Done.

[alon-f]

Reviewed 8 of 9 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @andrewmilson, @ilyalesokhin-starkware, and @shaharsamocha7)

[andrewmilson]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware and @shaharsamocha7)

[shaharsamocha7]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @ilyalesokhin-starkware)

[shaharsamocha7]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alon-f, @andrewmilson, and @ilyalesokhin-starkware)

---

crates/prover/src/examples/blake/air.rs line 513 at r3 (raw file):

) -> Result<(), VerificationError> {
    let channel = &mut MC::C::default();
    let commitment_scheme = &mut CommitmentSchemeVerifier::<MC>::new(stark_proof.config);

please add a TODO to consider to mix it in the channel seed.

Code quote:

stark_proof.config

[alon-f]

Reviewed 1 of 1 files at r4.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @andrewmilson, @ilyalesokhin-starkware, and @shaharsamocha7)

---

crates/prover/src/examples/blake/air.rs line 513 at r3 (raw file):

Previously, shaharsamocha7 wrote…

please add a TODO to consider to mix it in the channel seed.

Done.

[shaharsamocha7]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @ilyalesokhin-starkware)