Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove not used FieldOps trait #969

Merged
merged 1 commit into from
Jan 14, 2025
Merged

remove not used FieldOps trait #969

merged 1 commit into from
Jan 14, 2025

Conversation

ohad-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

ohad-starkware commented Jan 8, 2025

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ohad-starkware)


crates/prover/src/core/fields/mod.rs line 15 at r1 (raw file):

pub trait FieldOps<F: Field>: ColumnOps<F> {
    // TODO(Ohad): change to use a mutable slice.

Do you address this TODO in the following prs? (or not relevant?)

Code quote:

// TODO(Ohad): change to use a mutable slice.

Copy link
Collaborator Author

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)


crates/prover/src/core/fields/mod.rs line 15 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Do you address this TODO in the following prs? (or not relevant?)

not relevant

@ohad-starkware ohad-starkware merged commit f55a84a into dev Jan 14, 2025
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants