Add Bitwise Xor to Preprocessed Column Enum

[Gali-StarkWare]

This change is 

[Gali-StarkWare]

• Integrate Bitwise Builtin #395
• Integrate Verify Bitwise Xor 9 #402
• Bitwise Builtin Files #381
• Verify Bitwise Xor 9 Files #401
• Add Bitwise Xor to Preprocessed Column Enum #380 👈 (View in Graphite)
• Bitwise Xor Struct #379
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ohad-starkware]

I dont think the enum was correct here, if all you do is trivially expose the structs' methods, this is what a dyn trait is for.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, @Gali-StarkWare, and @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/cairo_air/preprocessed.rs line 55 at r2 (raw file):

    }

    /// Generates a column according to the preprocessed column chosen.

not sure this adds information

Code quote:

    /// Generates a column according to the preprocessed column chosen.

---

stwo_cairo_prover/crates/prover/src/cairo_air/preprocessed.rs line 70 at r2 (raw file):

    }

    /// Returns the values of the column at the given row.

this is less correct than the function's name

Code quote:

/// Returns the values of the column at the given row.

[shaharsamocha7]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alon-f, @andrewmilson, @Gali-StarkWare, and @ohad-starkware)

---

stwo_cairo_prover/crates/prover/src/cairo_air/preprocessed.rs line 35 at r5 (raw file):

}

pub enum PreProcessedColumn {

@Gali-StarkWare can you add a TODO to change the enum to a trait?

Code quote:

pub enum PreProcessedColumn {

[Gali-StarkWare]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alon-f, @andrewmilson, @ohad-starkware, and @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/cairo_air/preprocessed.rs line 35 at r5 (raw file):

Previously, shaharsamocha7 wrote…

@Gali-StarkWare can you add a TODO to change the enum to a trait?

Already done

[shaharsamocha7]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alon-f, @andrewmilson, and @ohad-starkware)

[ohad-starkware]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @alon-f, @andrewmilson, @Gali-StarkWare, and @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/cairo_air/preprocessed.rs line 65 at r3 (raw file):

Previously, Gali-StarkWare wrote…

I wanted to have it as a default implementation as a step before removing the rest of the gen_column_simd from the structs. That might be a reason why we would keep packed_at inside the trait when we switch to it. For now, done.

I agree, exposing packed_at so you can have a generic collect function (same as in pack_values)
albeit, it would be in a different trait.

---

stwo_cairo_prover/crates/prover/src/cairo_air/preprocessed.rs line 162 at r6 (raw file):

        let col: Col<SimdBackend, BaseField> = (0..((1 << self.log_size()) / N_LANES))
            .flat_map(|i| self.packed_at(i).to_array())
            .collect();

why do you need that to_array, try collecting the packed elements in to a vector?

Code quote:

        let col: Col<SimdBackend, BaseField> = (0..((1 << self.log_size()) / N_LANES))
            .flat_map(|i| self.packed_at(i).to_array())
            .collect();

[Gali-StarkWare]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @alon-f, @andrewmilson, @ohad-starkware, and @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/cairo_air/preprocessed.rs line 65 at r3 (raw file):

Previously, ohad-starkware (Ohad) wrote…

I agree, exposing packed_at so you can have a generic collect function (same as in pack_values)
albeit, it would be in a different trait.

OK

---

stwo_cairo_prover/crates/prover/src/cairo_air/preprocessed.rs line 162 at r6 (raw file):

Previously, ohad-starkware (Ohad) wrote…

why do you need that to_array, try collecting the packed elements in to a vector?

I couldn't without errors, you can suggest if you find a way

[ohad-starkware]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @alon-f, @andrewmilson, @Gali-StarkWare, and @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/cairo_air/preprocessed.rs line 155 at r7 (raw file):

            .collect();
        CircleEvaluation::new(CanonicCoset::new(self.log_size()).circle_domain(), col)
    }

Suggestion:

    pub fn gen_column_simd(&self) -> CircleEvaluation<SimdBackend, BaseField, BitReversedOrder> {
        CircleEvaluation::new(
            CanonicCoset::new(self.log_size()).circle_domain(),
            BaseColumn::from_simd(
                (0..(1 << (self.log_size() - LOG_N_LANES)))
                    .map(|i| self.packed_at(i))
                    .collect(),
            ),
        )
    }

[Gali-StarkWare]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @alon-f, @andrewmilson, @ohad-starkware, and @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/cairo_air/preprocessed.rs line 155 at r7 (raw file):

            .collect();
        CircleEvaluation::new(CanonicCoset::new(self.log_size()).circle_domain(), col)
    }

You got it

[ohad-starkware]

Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alon-f, @andrewmilson, and @shaharsamocha7)