Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevents closure parameters from being declared as refrences #7078

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

TomerStarkware
Copy link
Collaborator

No description provided.

@TomerStarkware TomerStarkware requested a review from orizi January 14, 2025 13:29
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)


crates/cairo-lang-semantic/src/diagnostic.rs line 1431 at r1 (raw file):

    MutableCapturedVariable,

    NonTraitTypeConstrained {

Suggestion:

    MutableCapturedVariable,
    NonTraitTypeConstrained {

@TomerStarkware TomerStarkware force-pushed the tomer/fix_mutable_params_in_closures branch from 4aa8d8a to 122cfdf Compare January 14, 2025 13:32
@TomerStarkware TomerStarkware force-pushed the tomer/prevent_ref_closure_params branch from 31bf5f7 to a9dea8d Compare January 14, 2025 13:54
Copy link
Collaborator Author

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-semantic/src/diagnostic.rs line 1431 at r1 (raw file):

    MutableCapturedVariable,

    NonTraitTypeConstrained {

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 6 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)


-- commits line 2 at r3:
rebase.

@TomerStarkware TomerStarkware force-pushed the tomer/prevent_ref_closure_params branch from a9dea8d to b5fd18c Compare January 14, 2025 14:47
@TomerStarkware TomerStarkware changed the base branch from tomer/fix_mutable_params_in_closures to main January 14, 2025 14:47
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

@TomerStarkware TomerStarkware force-pushed the tomer/prevent_ref_closure_params branch from b5fd18c to b7c54b2 Compare January 15, 2025 12:06
@TomerStarkware TomerStarkware added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit e635273 Jan 15, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants