Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added better support for concrete trait by output type. #7023

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jan 7, 2025

No description provided.

@orizi orizi requested a review from TomerStarkware January 7, 2025 23:50
@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the orizi/support-concrete-trait-by-output-ty branch from 635d8a4 to b79f368 Compare January 8, 2025 00:22
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)


crates/cairo-lang-semantic/src/expr/test_data/closure line 393 at r1 (raw file):


//! > expected_diagnostics
error: Inference cycle detected

@TomerStarkware can you remind me why this happens?

Code quote:

error: Inference cycle detected

Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-semantic/src/expr/test_data/closure line 393 at r1 (raw file):

Previously, orizi wrote…

@TomerStarkware can you remind me why this happens?

no, I did not fully resolve the first param issue. I just remember that before this pr you got ambiguity the first time and then the default solve for felt252, solved it the second time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants