Change table materialization logic when on_table_exists = 'rename' #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
hovaesco
force-pushed
the
hovaesco/rename-logic
branch
2 times, most recently
from
b1b7649
to
bf49c0b
Compare
|
Test are failing because of pypa/setuptools#4519 |
hovaesco
changed the title
hovaesco
force-pushed
the
hovaesco/rename-logic
branch
from
bf49c0b
to
1c86f7f
Compare
hovaesco
force-pushed
the
hovaesco/rename-logic
branch
from
1c86f7f
to
2615b20
Compare
damian3031
reviewed
Jul 30, 2024
tests/functional/adapter/materialization/test_on_table_exists.py
Outdated
Show resolved
Hide resolved
tests/functional/adapter/materialization/test_on_table_exists.py
Outdated
Show resolved
Hide resolved
tests/functional/adapter/materialization/test_on_table_exists.py
Outdated
Show resolved
Hide resolved
tests/functional/adapter/materialization/test_on_table_exists.py
Outdated
Show resolved
Hide resolved
damian3031
reviewed
Aug 1, 2024
tests/functional/adapter/materialization/test_on_table_exists.py
Outdated
Show resolved
Hide resolved
tests/functional/adapter/materialization/test_on_table_exists.py
Outdated
Show resolved
Hide resolved
hovaesco
force-pushed
the
hovaesco/rename-logic
branch
from
eb00329
to
19462de
Compare
hovaesco
force-pushed
the
hovaesco/rename-logic
branch
from
19462de
to
a93855e
Compare
damian3031
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #423
Checklist
README.mdupdated and added information about my changechangie newto create a changelog entry