-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: enhancement-322-Add-retry-mechanism-for-the-given-error #323
Closed
Thelin90
wants to merge
4
commits into
starburstdata:master
from
Thelin90:enhancement-322-Add-retry-mechanism-for-the-given-error
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,3 +10,4 @@ docker/dbt/.user.yml | |
.DS_Store | ||
.vscode/ | ||
logs/ | ||
venv |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
import decimal | ||
import os | ||
import re | ||
import time | ||
from abc import ABCMeta, abstractmethod | ||
from contextlib import contextmanager | ||
from dataclasses import dataclass, field | ||
|
@@ -505,11 +506,34 @@ def add_query(self, sql, auto_begin=True, bindings=None, abridge_sql_log=False): | |
|
||
return connection, cursor | ||
|
||
def execute(self, sql, auto_begin=False, fetch=False): | ||
_, cursor = self.add_query(sql, auto_begin) | ||
status = self.get_response(cursor) | ||
table = self.get_result_from_cursor(cursor) | ||
return status, table | ||
def execute( | ||
self, | ||
sql: str, | ||
auto_begin: bool = False, | ||
fetch: bool = False, | ||
max_retries=trino.constants.DEFAULT_MAX_ATTEMPTS, | ||
retry_delay: int = 1, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dataders can we pass a specific error message, retry_delay and max_retries from model configuration to here? |
||
): | ||
retry_count = 0 | ||
while retry_count < max_retries: | ||
try: | ||
_, cursor = self.add_query(sql, auto_begin) | ||
status = self.get_response(cursor) | ||
table = self.get_result_from_cursor(cursor) | ||
return status, table | ||
|
||
except DbtDatabaseError: | ||
retry_count += 1 | ||
if retry_count < max_retries: | ||
time.sleep(retry_delay) | ||
logger.info(f"Retrying query ({retry_count}/{max_retries})...") | ||
else: | ||
raise | ||
|
||
except Exception as exc: | ||
raise exc | ||
|
||
raise DbtRuntimeError("Failed to execute the query after maximum retries.") | ||
|
||
@classmethod | ||
def data_type_code_to_name(cls, type_code) -> str: | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trino.constants.DEFAULT_MAX_ATTEMPTS
is for connection timeout issues