refactor: remove redundancy and improve clarity #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* consolidate `initializeCandidateSet` and `organizeVotesByNextCandidate` into one method: `getCandidateMapFromVoteRecords` (reducing redundancy) * calculate `votesToRedistribute` earlier and pass that to `distributeVotes` instead of `quota` to not force `eliminateLowestCandidate` to pass 0 just for the sake of calculations * determine the `voteMultiplier` in the one place it is used: `redistributeToCandidates`, instead of earlier and passing it * to improve consistency, use `newQuotaTotalVotes` throughout the codebase as the construct to communicate changes to the totalVotes * streamline the code a bit (variable naming, using functions when they exist)
|
Please update your branch with master so that we can see the unit test results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initializeCandidateSetandorganizeVotesByNextCandidateinto one method:getCandidateMapFromVoteRecords(reducing redundancy)votesToRedistributeearlier and pass that todistributeVotesinstead ofquotato not forceeliminateLowestCandidateto pass 0 just for the sake of calculationsvoteMultiplierin the one place it is used:redistributeToCandidates, instead of earlier and passing itnewQuotaTotalVotesthroughout the codebase as the construct to communicate changes to the totalVotes