Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multislice support in ray #771

Merged
merged 11 commits into from
Oct 30, 2024
Merged

add multislice support in ray #771

merged 11 commits into from
Oct 30, 2024

Conversation

blahBlahhhJ
Copy link
Contributor

No description provided.

@blahBlahhhJ blahBlahhhJ requested a review from dlwh October 19, 2024 17:46
dlwh
dlwh reviewed Oct 19, 2024
View reviewed changes
Copy link
Member

@dlwh dlwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd really prefer we didn't require docker since we're not using it in marin.

src/levanter/infra/cli_helpers.py Outdated Show resolved Hide resolved
src/levanter/infra/cli_helpers.py Outdated Show resolved Hide resolved
src/levanter/infra/ray_tpu.py Outdated Show resolved Hide resolved
src/levanter/infra/ray_tpu.py Outdated Show resolved Hide resolved
@blahBlahhhJ blahBlahhhJ requested a review from dlwh October 28, 2024 20:36
dlwh
dlwh approved these changes Oct 28, 2024
View reviewed changes
src/levanter/infra/ray_tpu.py Outdated Show resolved Hide resolved
@blahBlahhhJ blahBlahhhJ merged commit 5ebf8ce into main Oct 30, 2024
8 checks passed
@blahBlahhhJ blahBlahhhJ deleted the jasonw/multislice_ray branch October 30, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwh dlwh dlwh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blahBlahhhJ @dlwh