-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subsampling LOO estimates with diff-est-srs-wor start #496
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 781e331.
I wanted to use R2, and as I had rewrote summary stats anyway, added R2 and made all mse, rmse, and R2 to use only normal approximation with as much shared computation as possible With the added R2 support, this PR will close also #483 |
I can take a look |
I have added some comments, but I'm not done with the review yet. Besides, I think documentation needs to be updated (at least re-roxygenized, but also progressr should be mentioned), the vignettes perhaps as well, and I haven't run |
I checked 5 comments in which you asked me to check something, and all others are good, but I replied to one |
Noticed 6th comment which is also ok. |
Sorry, I cannot find your reply. Do you remember to which comment it referred?:
|
A comment for commit de1cf4d (you may need to click a few times "Show more") |
So that would be #496 (comment), but I cannot see a reply from you there :/ Am I looking at the wrong place? |
I clicked the link in your last comment, and I can see the discussion with my comment. I'm copying my comment here
|
That's strange, I still cannot see any comment from you when clicking that link. But thanks for copying, I just pushed commit 7e61368 which drops the quotes. |
for RMSE in the case `!is.null(summaries_baseline)`, see <stan-dev#496 (comment)>
also take into account that `stat = "rmse"` does not need a PRNG seed anymore (and should produce a point estimate between the CI bounds)
to a value of zero; this was necessary due to a failing `stat = "R2"` test for `datafit`s where such negative squared standard errors numerically equal to zero occurred
for RMSE in the case `!is.null(summaries_baseline)`, see <#496 (comment)>
for RMSE in the case `!is.null(summaries_baseline)`, see <#496 (comment)>
for RMSE in the case `!is.null(summaries_baseline)`, see <#496 (comment)>
Work in progress.
Tested with
Notes
cv_varsel
if nloo<n and fast PSIS-LOO result is not yet available, fast PSIS-LOO result is computedcv_varsel
if nloo<n, fast PSIS-LOO result is stored in slot $summaries_fastNext
tagging @n-kall