Chore/template upgrade #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff against template repo to pull in newer pre-commit style of testing/formatting
Added all the missing type hints, had to refactor some code to return correct types, add create-collection to rtc cli : todo some changes need to be in the Changelog/Readme
This was referenced Jan 13, 2023
gadomski
requested changes
Jan 17, 2023
add link to template version Co-authored-by: Pete Gadomski <[email protected]>
not increment version yet Co-authored-by: Pete Gadomski <[email protected]>
Remove TODO that is completed.
gadomski
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you submit a pull request, please fill in the following:
Related Issue(s):
Please add links (if any) to related github issues.
#22
Description:
Upgraded the scripts and requirements based on the latest stactools-template and stactools version. This upgrades all the linting tools and includes enabling pre-commit. As a result all of the type hinting had to be overhauled throughout the package in order to pass all the format, linting, and tests. This includes some improvements to error handling in code with additional RaiseErrors when invalid or missing values are returned from XML metadata parsing.
Context - the next PR after this will be based on this upgrade (adds collection, and tests for GRD)
Note - some features required Python 3.8 so 3.7 was dropped and 3.10 was added (consistent with upstream)
Question
Should the version number be bumped, or does that only happen before release? I bumped it to 0.3.1 as it's not the same as 0.3.0.
PR checklist:
scripts/format).scripts/lint).scripts/test).