Add timestamp calculation to all block responses #5470
Draft
+266
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
commented
Nov 16, 2024
|
|
||
| sortition_state | ||
| .cur_sortition | ||
| .burn_header_timestamp |
There was a problem hiding this comment.
This won't work i don't think...cause the burn header timestamp could be super duper old. Like this could be the second, third,...,Nth tenure extend. I will need to track the current tenure timestamp start better I think/Needs to reset per tenure extend.
There was a problem hiding this comment.
We can relatively easily check if a block has a TenureChange payload in it (doesn't matter if it's for an extend or new block), and then use that as our "start" for the timer
jferrant
commented
Nov 16, 2024
| @@ -190,6 +193,7 @@ impl BlockInfo { | |||
| } else { | |||
| self.signed_self.get_or_insert(get_epoch_time_secs()); | |||
| } | |||
| self.processed_time = Some(get_epoch_time_secs()); | |||
There was a problem hiding this comment.
This needs to be updated to use the block validate response process time (which will most likely be a nmb secs rather than a timestamp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass. Haven't tested this at all and this was just first thoughts.