-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tenure_extend_timestamp to Block Response Accept messages #5466
base: develop
Are you sure you want to change the base?
Conversation
@@ -1,6 +1,6 @@ | |||
stacks_private_key = "6a1fc1a3183018c6d79a4e11e154d2bdad2d89ac8bc1b0a021de8b4d28774fbb01" | |||
node_host = "127.0.0.1:20443" | |||
endpoint = "localhost:30000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this to make config to str test pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be backwards compatible - right now it'll fail if the payload doesn't have the timestamp. I think there's already a unit test with fixtures for backwards compatibility
Signed-off-by: Jacinta Ferrant <[email protected]>
db013bc
to
52e0d1f
Compare
I mean I can easily make this default fill the timestamp with u64::MAX if not found. Not sure that is considered backwards compatible enough. I don't actually see why this has to be backwards compatible though. It would of course require signers to upgrade, by why does this need to be backwards compatible? (I just assumed not required as we do not back process Block Responses nor do we store them anywhere internally in the signers DB....EDIT: I think I just answered my question though. miners would have issues.) |
Signed-off-by: Jacinta Ferrant <[email protected]>
Since we are doing this without a hard fork, miners that upgrade should be able to talk to signers that have not upgraded, and vice versa. |
haha I just answered this in my own response to Hank right before I saw this XD |
Signed-off-by: Jacinta Ferrant <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Should we merge this into a broader feature branch? This PR itself is probably fine to merge into develop, but with other PRs we'll probably want some other base branch.
Needed to complete #5434